-
Notifications
You must be signed in to change notification settings - Fork 7
Kitchen scene #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kitchen scene #407
Conversation
0d061d9 to
991c1b9
Compare
391f932 to
9fe483e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EzraBrooks are we committing onnx models into the robot configs, or somewhere else now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question for next 2 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have them in the robot configurations, e.g., in the models folder of the lab_sim. We could move them all in their own package.
src/moveit_pro_franka_configs/franka_arm_sim/objectives/close_gripper.xml
Outdated
Show resolved
Hide resolved
| <!--//////////--> | ||
| <BehaviorTree | ||
| ID="Move Away" | ||
| _description="Move the robot away from the main scene camera." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this objective? Why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The robot is in front of the scene camera. When I take a snapshot, I move it away from the camera to have a better pointcloud. Otherwise, the microwave would be hidden.
src/moveit_pro_franka_configs/franka_arm_sim/objectives/open_gripper.xml
Outdated
Show resolved
Hide resolved
src/moveit_pro_franka_configs/franka_arm_sim/objectives/take_scene_camera_snapshot.xml
Outdated
Show resolved
Hide resolved
davetcoleman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename this package to kitchen_sim
ae420aa to
e7d29a5
Compare
davetcoleman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, needs another engineer approver
src/moveit_pro_franka_configs/kitchen_sim/description/mujoco/MUJOCO_LOG.TXT
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did @EzraBrooks weigh in on this file?
e7d29a5 to
99705fc
Compare
bgill92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
Issue
https://github.com/PickNikRobotics/moveit_pro/issues/13868
Description
Run MoveIt Pro with package:
franka_arm_sim