Skip to content

Conversation

@kineticsystem
Copy link

@kineticsystem kineticsystem commented Sep 2, 2025

Issue

https://github.com/PickNikRobotics/moveit_pro/issues/13868

Description

Run MoveIt Pro with package: franka_arm_sim

image

@kineticsystem kineticsystem self-assigned this Sep 2, 2025
@kineticsystem kineticsystem force-pushed the pr-kitchen-scene branch 10 times, most recently from 0d061d9 to 991c1b9 Compare September 9, 2025 17:29
@kineticsystem kineticsystem force-pushed the pr-kitchen-scene branch 8 times, most recently from 391f932 to 9fe483e Compare September 11, 2025 18:06
@kineticsystem kineticsystem marked this pull request as ready for review September 11, 2025 18:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EzraBrooks are we committing onnx models into the robot configs, or somewhere else now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for next 2 files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have them in the robot configurations, e.g., in the models folder of the lab_sim. We could move them all in their own package.

<!--//////////-->
<BehaviorTree
ID="Move Away"
_description="Move the robot away from the main scene camera."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this objective? Why is it needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The robot is in front of the scene camera. When I take a snapshot, I move it away from the camera to have a better pointcloud. Otherwise, the microwave would be hidden.

Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this package to kitchen_sim

@kineticsystem kineticsystem force-pushed the pr-kitchen-scene branch 5 times, most recently from ae420aa to e7d29a5 Compare September 12, 2025 11:24
Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs another engineer approver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did @EzraBrooks weigh in on this file?

Copy link

@bgill92 bgill92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@kineticsystem kineticsystem merged commit caf3629 into main Sep 15, 2025
5 checks passed
@kineticsystem kineticsystem deleted the pr-kitchen-scene branch September 16, 2025 13:42
shaur-k pushed a commit that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants