Skip to content

Conversation

@dsobek
Copy link

@dsobek dsobek commented Dec 6, 2024

Not to be merged until https://github.com/PickNikRobotics/moveit_studio/pull/9577 is merged.

Adds build args for building the nvidia version of this workspace. Simply uncomment these args in docker-compose.yaml

@dsobek dsobek self-assigned this Dec 6, 2024
@dsobek dsobek force-pushed the docker-yaml-merge-example branch 2 times, most recently from 3ef4179 to b1be1d3 Compare December 6, 2024 19:47
@dsobek dsobek force-pushed the docker-yaml-merge-example branch from b1be1d3 to 108f5aa Compare December 6, 2024 20:03
@dsobek dsobek requested review from MikeWrock and dyackzan December 6, 2024 20:10
@shaur-k
Copy link
Collaborator

shaur-k commented Dec 12, 2024

this is mergable now right?

@dsobek
Copy link
Author

dsobek commented Dec 12, 2024

this is mergable now right?

No this only makes sense to merge in once 7.0.0 is out.

@dsobek dsobek changed the base branch from main to v7.0 December 16, 2024 19:02
@dsobek
Copy link
Author

dsobek commented Dec 16, 2024

I've changed this PR to merge into the v7.0 branch so I believe this is ok to merge now.

@dsobek dsobek merged commit 63364f9 into v7.0 Dec 16, 2024
4 checks passed
@dsobek dsobek deleted the docker-yaml-merge-example branch December 16, 2024 19:11
MikeWrock added a commit that referenced this pull request Jan 6, 2025
dyackzan pushed a commit that referenced this pull request Jan 21, 2025
shaur-k pushed a commit that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants