Skip to content

Conversation

@MikeWrock
Copy link
Collaborator

bind mounting this entire folder makes it way more likely to invalidate the docker cache (if any file is touched it will be invalidated, including changes to the install and log folder). All we really need is the package.xmls for this stage but I think we can watch the whole src folder for changes.

How to test:
First:

moveit_pro dev
🐙MoveIt Pro🐙:~/user_ws$ touch hello
Ctrl + D
moveit_pro dev

Notice the base image remains cached

Bonus test: Modify a package.xml and see how the rosdep install in the base layer reruns

Undo this fix, and:

moveit_pro dev
🐙MoveIt Pro🐙:~/user_ws$ touch world
Ctrl + D
moveit_pro dev

Notice how the base image has to apt-update even though the dependencies remain unchanged

@MikeWrock MikeWrock requested a review from shaur-k September 22, 2025 23:02
@MikeWrock MikeWrock self-assigned this Sep 22, 2025
@MikeWrock MikeWrock added this to the 8.7 milestone Sep 22, 2025
@MikeWrock MikeWrock enabled auto-merge September 23, 2025 00:28
@MikeWrock MikeWrock merged commit 9292bec into v8.7 Sep 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants