Improve docker cache utiliaztion #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind mounting this entire folder makes it way more likely to invalidate the docker cache (if any file is touched it will be invalidated, including changes to the install and log folder). All we really need is the package.xmls for this stage but I think we can watch the whole src folder for changes.
How to test:
First:
Notice the base image remains cached
Bonus test: Modify a package.xml and see how the rosdep install in the base layer reruns
Undo this fix, and:
Notice how the base image has to apt-update even though the dependencies remain unchanged