update kinova_sim reset sim Objective to disable controllers #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsobek
approved these changes
Nov 14, 2025
marioprats
force-pushed
the
reset-keyframe-fix
branch
from
5eb63f2 to
515d2e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use the core "Reset Mujoco Sim" Objective. Instead, have a custom one to disable the Kinova-specific controllers before resetting the Mujoco keyframe. This makes sure all Kinova controllers are disabled when the keyframe is reset.
Needs https://github.com/PickNikRobotics/moveit_pro/pull/15299
Screencast.from.11-12-2025.03.18.13.PM.webm
Closes https://github.com/PickNikRobotics/moveit_pro/issues/14822