Override ResetMujocoSim in lab_sim to deactivate all controllers #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioprats
force-pushed
the
lab_sim_custom_reset
branch
from
1800d5f to
599760e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch for https://github.com/PickNikRobotics/moveit_pro/issues/15680
Overrides "Reset Mujoco Sim" to disable all controllers before actually resetting the mujoco keyframe.
Unfortunately we can't put this in the core Objective because different configs will have different controllers. There isn't a common set of controllers. And parameterizing the Objective with controller names would require all user configs to have their own "reset" Objective anyway, to set the parameters.
Closes https://github.com/PickNikRobotics/moveit_pro/issues/15680
Screencast.from.12-15-2025.09.17.13.AM.webm