Skip to content

Conversation

@marioprats
Copy link

Cherry-pick moveit@3cd567e, with some conflict solving

@marioprats marioprats requested a review from sjahr January 24, 2025 15:45
@marioprats marioprats changed the base branch from ros2 to ros2-new January 24, 2025 16:56
@marioprats
Copy link
Author

@sjahr Pre-commit is failing because it's unable to find clang-tidy-12, which seems unrelated to this PR. Has it worked before or do you normally bypass the check?

@marioprats
Copy link
Author

I have reverted the change that switches to clang-format-14, because then some other issues show up
Looks like CI is just broken in this repo (it cant' find clang-format-12). We should check what upstream MTC is using these days and apply their updates, which probably requires merging their recent changes.
That can be a can of worms, so I think we should commit this change, and fix CI / merge upstream in a separate effort.

@marioprats marioprats merged commit 21f6a91 into ros2-new Jan 27, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants