Skip to content

Redundant test dependencies in package.xml of robotiq_hardware_tests and robotiq_description #94

@Plumezz

Description

@Plumezz

Hello, after building and testing this project with branch develop, I found something unexpected.

I noticed the package.xml files in the package robotiq_hardware_tests and robotiq_description contains the following content which means a format check.

  <test_depend>ament_lint_auto</test_depend>
  <test_depend>ament_lint_common</test_depend>

But there are no test section in CMakeLists.txt .

So I think if we want the ament_lint tools to do a format check, maybe need add the testing section in the CMakeLists.txt like following:

if(BUILD_TESTING)
  find_package(ament_lint_auto REQUIRED)
  ament_lint_auto_find_test_dependencies()
endif()

After adding the content, amen_lint_tools like ament_copyright, ament_lint_cmake, ament_xmllint should be executed correctly.

If we do not need the ament_lint_tools, I think the test_depend might be a redundant dependency that could be removed to reduce the burden of project maintenance.

I would appreciate it if you could tell me how do you think of this?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions