Skip to content

Extend AssertThatIsPositive Refaster rule#1943

Merged
rickie merged 1 commit intomasterfrom
sschroevers/update-AssertThatIsPositive
Nov 26, 2025
Merged

Extend AssertThatIsPositive Refaster rule#1943
rickie merged 1 commit intomasterfrom
sschroevers/update-AssertThatIsPositive

Conversation

@Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Nov 1, 2025 •
edited
Loading

❗ This PR is on top of #1927. ❗

Suggested commit message:

Extend `AssertThatIsPositive` Refaster rule (#1943)

By simplifying expressions referencing `Duration#isPositive()`,
introduced with Java 18.

@Stephan202 Stephan202 added this to the 0.27.0 milestone Nov 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 mentioned this pull request Nov 1, 2025
Merged
mohamedsamehsalah
mohamedsamehsalah approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🏫

@rickie rickie force-pushed the sschroevers/target-jdk-21 branch 2 times, most recently from 96f070e to 67d7d5f Compare November 6, 2025 15:45
Base automatically changed from sschroevers/target-jdk-21 to master November 6, 2025 16:09
@Stephan202 Stephan202 force-pushed the sschroevers/update-AssertThatIsPositive branch from 89707b5 to b8de3fd Compare November 11, 2025 21:19
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/update-AssertThatIsPositive branch from b8de3fd to ce41464 Compare November 26, 2025 10:33
@rickie
Copy link
Member

rickie commented Nov 26, 2025

/integration-test

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Suggested commit message:

Extend `AssertThatIsPositive` Refaster rule (#1943)

By simplifying expressions referencing `Duration#isPositive()`,
introduced with Java 18.

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 @rickie
Extend AssertThatIsPositive Refaster rule
ef642ec 
By simplifying expressions referencing `Duration#isPositive()`,
introduced with Java 18.
@rickie rickie force-pushed the sschroevers/update-AssertThatIsPositive branch from ce41464 to ef642ec Compare November 26, 2025 12:01
@rickie
Copy link
Member

rickie commented Nov 26, 2025 •
edited
Loading

/integration-test -> Build 🏁 .

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rickie rickie merged commit 2dc20c9 into master Nov 26, 2025
19 checks passed
@rickie rickie deleted the sschroevers/update-AssertThatIsPositive branch November 26, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickie rickie rickie approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees

No one assigned

Labels

improvement

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Stephan202 @rickie @mohamedsamehsalah