Merged
Conversation
Stephan202
added
the
chore
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Stephan202
commented
Oct 19, 2025
Comment on lines
+487
to
+498
| /** Prefer {@link List#getFirst()} over less idiomatic alternatives. */ | ||
| static final class ListGetFirst<T> { | ||
| @BeforeTemplate | ||
| T before(List<T> list) { | ||
| return list.get(0); | ||
| } | ||
|
|
||
| @AfterTemplate | ||
| T after(List<T> list) { | ||
| return list.getFirst(); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Not all list.get(0) expressions are replaced by the self check. Requires further investigation.
1 task
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Stephan202
force-pushed
the
sschroevers/target-jdk-21
branch
from
0bcc409 to
7252240
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Member
Author
Initially the new rules didn't match for invocations on |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Stephan202
force-pushed
the
sschroevers/target-jdk-21
branch
from
91bde89 to
8e4c632
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
This was referenced Oct 31, 2025
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
This was referenced Nov 1, 2025
Stephan202
force-pushed
the
sschroevers/target-jdk-21
branch
from
88fe7a6 to
449b750
Compare
This was referenced Nov 1, 2025
Member
Author
1 task
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
5 tasks
rickie
approved these changes
Nov 6, 2025
Member
rickie
left a comment
rickie
left a comment
There was a problem hiding this comment.
Perfectly structured PR. Nice effort and I like the JDK 21 improvements 🚀 !
Amazing work @Stephan202 !
rickie
force-pushed
the
sschroevers/target-jdk-21
branch
from
ac3ee99 to
96f070e
Compare
WIP: - Move Refaster rule changes to a separate PR. - Investigate other cleanup opportunities.
rickie
force-pushed
the
sschroevers/target-jdk-21
branch
from
96f070e to
67d7d5f
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
|
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗
To be merged after #1942. ❗Suggested commit message (to be augmented later):
This is a
draftPR, to be merged just before we upgrade to the next version of Error Prone, which itself will target Java 21. Open points:Release one more version of Error Prone Support targeting Java 17 before merging this PR.✔️Move the Refaster rule changes to a separate PR, to be merged after this one.✔️Drop the Java 17 assumption made by✔️website/generate-version-compatibility-overview.sh.Understand why not all✔️list.get(0)occurrences are flagged by the newListGetFirstRefaster rule.Investigate other cleanup opportunities and improvements that may be unlocked by targeting Java 21.✔️Note that raising the build baseline to Java 25 isn't strictly necessary, but it (a) matches what we do for Maven (i.e., always requires the latest version) and (b) means that we retain the need for the Maven Toolchains setup (otherwise I'd be torn to drop all that for the time being, only to have to reintroduce it again later). I propose that we officially move to a cadence where we build with the latest LTS and target the oldest LTS supported by Error Prone.