Improve type casting #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow _cast to parse list values from JSON strings in addition to comma-separated values. - This enables environment variables like '["a", "b", "c"]' to be parsed correctly into Python lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR extends the
_castfunction’slisthandling to support JSON-formatted strings in addition to simple comma-separated strings. Closes #5Before
After
Why
Environment variables may be supplied as valid JSON arrays (especially in containerized environments or
.envfiles).Previously,
_castonly supported comma-separated lists, which caused incorrect parsing for JSON-style inputs.Tests
Updated test suite to include
test_cast_list_json_validfor JSON lists.