Pre-Tournament 1 #43
Merged
Pre-Tournament 1 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of comments. (darn java objects incompatible kwarg support :/)
- Merge Processing and Metadata Classes together - Remove decode from name - Remove obelisk tags from navigation. See obelisk/motif instead - clean up class naming, types, and line cleanliness - Add some simple methods - Add placeholder shooting offset
…tags with AprilTagDetection integration. Now has detect goal and field goal localization
… for neutral alliance. Update method names.
- Simplified `moveToNextOpenIntake` logic using `takeIf` for cleaner null checks. - Renamed `getArtifact` to `detectArtifact` to not confuse from getting artifact positional indexing and implemented artifact detection logic based on sensor color values. - Added `currentSensor` method to determine the active sensor based on motor state. - Introduced `scanArtifact` method to handle artifact scanning with optional LED control. Cleans up need to call correct intake/outtake sensor method. Instead has context awareness based on enum. - Improved readability and modularity of artifact detection and intake handling.
…plename getter in hardware component
… properties to Spindexer and update SpindexerTest
- Define wrapping behavior - Rename Class in Constants - Used some kotlin magic to clean of duplicating motor attribute mapping
…tions in their corresponding state
…l logic - Replaced NormalizedColorSensor with RevColorSensor for better abstraction and encapsulation. - Removed unused imports and redundant methods. - Added utility methods to RevColorSensor for normalized RGB and distance retrieval. - Consolidated moveToNextOpenIntake and moveToOutakeNext into a single moveToNext function to simplify state transitions. - Enhanced motor control logic with the new runMotorToState method for cleaner and reusable motor operations. - Simplified artifact scanning and motor state transitions for improved maintainability.
…into RedGoalAuto # Conflicts: # TeamCode/src/main/kotlin/pioneer/Constants.kt # TeamCode/src/main/kotlin/pioneer/decode/Obelisk.kt # TeamCode/src/main/kotlin/pioneer/hardware/Camera.kt # TeamCode/src/main/kotlin/pioneer/helpers/MathUtils.kt
- Cleanup camera and april tag methods after merge - clean artifacts methods in spindexer. add rescanAllArtifacts method - Move opmode tests to other
MGross21
requested review from
Braedeng0,
milopeters and
nwazus
and removed request for
Braedeng0
MGross21
commented
Dec 5, 2025
...roller/src/main/java/org/firstinspires/ftc/robotcontroller/external/samples/SensorColor.java
Show resolved
Hide resolved
Member
Author
There was a problem hiding this comment.
Should this be uncommented or deleted?
…ideAuto and TeleopDriver2 to use new pose calculations
…date RedGoalSideAuto to use dynamic alliance color
…alizing Points correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMP_BOTrobot type with added hardware components (Intake,Turret,Spindexer,Launcher), alliance color handling, and anupdateAllmethod for synchronized hardware/localizer updates.Artifactenum for cleaner color and swatch processing.GoalTagenum andGoalTagProcessorto unify AprilTag goal metadata, alliance-aware tag selection, and pose computation.