-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Rev to component docs for Connect #14983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@dannyroosevelt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 30 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces significant updates to the documentation for the Pipedream Connect API, enhancing clarity and detail regarding new API endpoints for managing deployed triggers. It also updates the method for deploying triggers and includes expanded examples for API interactions. Additionally, modifications are made to the documentation for the Pipedream REST API, including new sections on webhooks and clarifications on connected accounts. Overall, these changes aim to improve user understanding and usage of the API functionalities. Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs-v2/pages/connect/components.mdx (1)
35-40: Consider clarifying the search API functionalityThe callout mentions skipping steps by using the search API but doesn't provide details about how the natural language prompt works.
Consider adding a brief example of a natural language prompt and its expected results:
-You can also skip steps 1 and 2 if you already know the component you want to use or if you'd prefer to [pass a natural language prompt to Pipedream's component search API](/rest-api#search-for-registry-components). +You can also skip steps 1 and 2 if you: +1. Already know the component you want to use, or +2. Prefer to use [Pipedream's component search API](/rest-api#search-for-registry-components) with natural language prompts like "send a Slack message when a new GitHub issue is created"🧰 Tools
🪛 LanguageTool
[style] ~40-~40: Consider a shorter alternative to avoid wordiness.
Context: ...h-for-registry-components). In order to find the right trigger or action to con...(IN_ORDER_TO_PREMIUM)
docs-v2/pages/connect/api.mdx (1)
2031-2034: Consider rewording for concisenessThe section introduction could be more concise while maintaining clarity.
-List all of the deployed triggers for a given user. +List all deployed triggers for a given user.🧰 Tools
🪛 LanguageTool
[style] ~2033-~2033: Consider removing “of” to be more concise
Context: ... ``` #### List deployed triggers List all of the deployed triggers for a given user. ``...(ALL_OF_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
docs-v2/pages/connect/api.mdx(6 hunks)docs-v2/pages/connect/components.mdx(3 hunks)docs-v2/pages/rest-api/index.mdx(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/connect/components.mdx
[style] ~40-~40: Consider a shorter alternative to avoid wordiness.
Context: ...h-for-registry-components). In order to find the right trigger or action to con...
(IN_ORDER_TO_PREMIUM)
[style] ~76-~76: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...for the app Once you have the app you want to use, now you can list the triggers and/...
(REP_WANT_TO_VB)
[uncategorized] ~76-~76: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t app. We'll list the actions for Gitlab and we'll pass the name_slug gitlab as ...
(COMMA_COMPOUND_SENTENCE)
[style] ~147-~147: Consider a shorter alternative to avoid wordiness.
Context: ...## Retrieve the component's definition In order to run a component for your end users, you...
(IN_ORDER_TO_PREMIUM)
docs-v2/pages/connect/api.mdx
[style] ~2033-~2033: Consider removing “of” to be more concise
Context: ... ``` #### List deployed triggers List all of the deployed triggers for a given user. ``...
(ALL_OF_THE)
🔇 Additional comments (5)
docs-v2/pages/connect/components.mdx (2)
29-31: LGTM! Helpful callout for API reference
The callout effectively directs users to the full API documentation while providing a quick reference for examples.
Line range hint 704-704: Important update about cascading deletion behavior
The documentation now correctly reflects that deleting an account will also delete any associated deployed triggers. This is a critical change that users should be aware of.
🧰 Tools
🪛 LanguageTool
[style] ~40-~40: Consider a shorter alternative to avoid wordiness.
Context: ...h-for-registry-components). In order to find the right trigger or action to con...
(IN_ORDER_TO_PREMIUM)
[style] ~76-~76: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...for the app Once you have the app you want to use, now you can list the triggers and/...
(REP_WANT_TO_VB)
[uncategorized] ~76-~76: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t app. We'll list the actions for Gitlab and we'll pass the name_slug gitlab as ...
(COMMA_COMPOUND_SENTENCE)
[style] ~147-~147: Consider a shorter alternative to avoid wordiness.
Context: ...## Retrieve the component's definition In order to run a component for your end users, you...
(IN_ORDER_TO_PREMIUM)
docs-v2/pages/rest-api/index.mdx (1)
446-449: LGTM! Clear separation of concerns
The callout effectively directs users to the appropriate documentation for running components on behalf of end users.
docs-v2/pages/connect/api.mdx (2)
Line range hint 1882-1920: Update code examples to reflect new method name
The code examples have been updated to use deployTrigger instead of runAction, which better reflects the actual operation being performed.
2335-2383: LGTM! Comprehensive documentation for trigger deletion
The new section thoroughly documents the trigger deletion endpoint, including path parameters, query parameters, and example requests/responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
docs-v2/pages/connect/components.mdx (4)
37-39: Consider rephrasing for clarity and conciseness.The callout message could be more concise while maintaining its helpfulness.
-You can also skip steps 1 and 2 if you already know the component you want to use or if you'd prefer to [pass a natural language prompt to Pipedream's component search API](/rest-api#search-for-registry-components). +Skip steps 1 and 2 if you either know the desired component or prefer using [Pipedream's natural language component search API](/rest-api#search-for-registry-components).
43-45: Add language specification to the code block.Enhance syntax highlighting by specifying the language for the code block.
-```text +```http GET /v1/connect/apps?q=gitlab--- Line range hint `345-354`: **Consider restructuring for better readability.** The dynamic props section introduction could be more concise and clearer. ```diff -The set of props that a component can accept might not be static, and can change -depending on the values of prior props. Props that behave this way are called -[dynamic props](/components/api#dynamic-props), and they need to be configured -in a different way. Props that are dynamic will have a `reloadProps` attribute -set to `true` in the component's code. +[Dynamic props](/components/api#dynamic-props) are properties whose available options depend on values of previously configured props. These props are marked with `reloadProps: true` in the component's code and require special configuration.
Line range hint
1-600: Consider adding a table of contents and quick reference section.The documentation is comprehensive but could benefit from:
- A table of contents at the beginning for easier navigation
- A "Quick Reference" section with common API endpoints
- A "Troubleshooting" section for common issues
This would improve the overall documentation structure and make it more user-friendly.
🧰 Tools
🪛 LanguageTool
[style] ~40-~40: Consider a shorter alternative to avoid wordiness.
Context: ...h-for-registry-components). In order to find the right trigger or action to con...(IN_ORDER_TO_PREMIUM)
[style] ~76-~76: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...for the app Once you have the app you want to use, now you can list the triggers and/...(REP_WANT_TO_VB)
[uncategorized] ~76-~76: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t app. We'll list the actions for Gitlab and we'll pass thename_sluggitlabas ...(COMMA_COMPOUND_SENTENCE)
[style] ~147-~147: Consider a shorter alternative to avoid wordiness.
Context: ...## Retrieve the component's definition In order to run a component for your end users, you...(IN_ORDER_TO_PREMIUM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs-v2/pages/connect/components.mdx(4 hunks)
🧰 Additional context used
🪛 LanguageTool
docs-v2/pages/connect/components.mdx
[style] ~40-~40: Consider a shorter alternative to avoid wordiness.
Context: ...h-for-registry-components). In order to find the right trigger or action to con...
(IN_ORDER_TO_PREMIUM)
[style] ~76-~76: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...for the app Once you have the app you want to use, now you can list the triggers and/...
(REP_WANT_TO_VB)
[uncategorized] ~76-~76: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t app. We'll list the actions for Gitlab and we'll pass the name_slug gitlab as ...
(COMMA_COMPOUND_SENTENCE)
[style] ~147-~147: Consider a shorter alternative to avoid wordiness.
Context: ...## Retrieve the component's definition In order to run a component for your end users, you...
(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (1)
docs-v2/pages/connect/components.mdx (1)
29-31: LGTM! Well-placed informational callout.
The callout effectively directs users to the full API reference while setting context for the examples that follow.
WHY
Summary by CodeRabbit