MCP - bump sdk version, update readme #16356
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update introduces new development instructions in the documentation for running the MCP server locally, including details on enabling debug output with an environment variable. Development scripts in the package configuration are modified to automatically load environment variables from a Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Terminal
participant MCP_Server
participant Pipecream_Connect_API
Developer->>Terminal: Run npm run dev:sse (with/without PD_SDK_DEBUG)
Terminal->>MCP_Server: Start server (dotenv loads .env)
MCP_Server->>MCP_Server: Listen on 0.0.0.0:PORT
MCP_Server->>Pipecream_Connect_API: (If PD_SDK_DEBUG=true) Log requests/responses
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
modelcontextprotocol/src/sse.tsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
modelcontextprotocol/README.md (3)
42-42: Fix grammatical issue in section title.The phrase "Running the server via locally for development" contains awkward phrasing.
-### Running the server via locally for development +### Running the server locally for development
54-54: Fix repeated word.There's a repeated word "add" in this line.
-optionally you can add add the env var `PD_SDK_DEBUG=true` to the above commands to dump requests and responses to the Pipecream Connect API. +optionally you can add the env var `PD_SDK_DEBUG=true` to the above commands to dump requests and responses to the Pipecream Connect API.🧰 Tools
🪛 LanguageTool
[duplication] ~54-~54: Possible typo: you repeated a word.
Context: ...m run dev:stdio ``` optionally you can add add the env varPD_SDK_DEBUG=trueto the ...(ENGLISH_WORD_REPEAT_RULE)
54-54: Fix typo in API name.There's a typo in "Pipecream" - it should be "Pipedream".
-optionally you can add add the env var `PD_SDK_DEBUG=true` to the above commands to dump requests and responses to the Pipecream Connect API. +optionally you can add the env var `PD_SDK_DEBUG=true` to the above commands to dump requests and responses to the Pipedream Connect API.🧰 Tools
🪛 LanguageTool
[duplication] ~54-~54: Possible typo: you repeated a word.
Context: ...m run dev:stdio ``` optionally you can add add the env varPD_SDK_DEBUG=trueto the ...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
modelcontextprotocol/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
modelcontextprotocol/README.md(1 hunks)modelcontextprotocol/package.json(2 hunks)modelcontextprotocol/src/sse.ts(1 hunks)
🧰 Additional context used
🪛 LanguageTool
modelcontextprotocol/README.md
[duplication] ~54-~54: Possible typo: you repeated a word.
Context: ...m run dev:stdio ``` optionally you can add add the env var PD_SDK_DEBUG=true to the ...
(ENGLISH_WORD_REPEAT_RULE)
🪛 GitHub Actions: Pull Request Checks
modelcontextprotocol/README.md
[warning] 1-1: File ignored because of a matching ignore pattern. Use "--no-ignore" to disable file ignore settings or use "--no-warn-ignored" to suppress this warning.
modelcontextprotocol/src/sse.ts
[error] 163-163: ESLint: A space is required after ',' (comma-spacing)
🪛 GitHub Check: Lint Code Base
modelcontextprotocol/src/sse.ts
[failure] 163-163:
A space is required after ','
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pnpm publish
🔇 Additional comments (4)
modelcontextprotocol/package.json (2)
10-11: Improved developer experience with automatic environment variable loading!Adding
-r dotenv/configto the dev scripts enables automatic loading of environment variables from a.envfile, making local development easier and more consistent with the new instructions in the README.
23-23: SDK version bump looks good.Updating the
@pipedream/sdkdependency from^1.4.0to^1.5.2ensures compatibility with the latest features and bug fixes.modelcontextprotocol/src/sse.ts (1)
163-163: Improved server accessibility by listening on all interfaces.Binding to "0.0.0.0" allows the server to accept connections on all IPv4 interfaces instead of just localhost, making it more accessible for local development and testing from other devices.
🧰 Tools
🪛 GitHub Check: Lint Code Base
[failure] 163-163:
A space is required after ','🪛 GitHub Actions: Pull Request Checks
[error] 163-163: ESLint: A space is required after ',' (comma-spacing)
modelcontextprotocol/README.md (1)
42-66: Great addition of local development instructions!The new section provides clear instructions for running the MCP server locally, including how to enable debug output. This will be very helpful for developers.
🧰 Tools
🪛 LanguageTool
[duplication] ~54-~54: Possible typo: you repeated a word.
Context: ...m run dev:stdio ``` optionally you can add add the env varPD_SDK_DEBUG=trueto the ...(ENGLISH_WORD_REPEAT_RULE)
modelcontextprotocol/src/sse.ts
Outdated
|
|
||
| app | ||
| .listen(port, () => { | ||
| .listen(port,"0.0.0.0", () => { |
There was a problem hiding this comment.
Fix linting error: missing space after comma.
There's a missing space after the comma in .listen(port,"0.0.0.0", () => {.
-.listen(port,"0.0.0.0", () => {
+.listen(port, "0.0.0.0", () => {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .listen(port,"0.0.0.0", () => { | |
| .listen(port, "0.0.0.0", () => { |
🧰 Tools
🪛 GitHub Check: Lint Code Base
[failure] 163-163:
A space is required after ','
🪛 GitHub Actions: Pull Request Checks
[error] 163-163: ESLint: A space is required after ',' (comma-spacing)
1 participant
WHY
Summary by CodeRabbit
Documentation
Chores
Bug Fixes