Skip to content

MCP - bump sdk version, update readme #16356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

MCP - bump sdk version, update readme #16356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec25747
bump sdk version, update readme
jsendo Apr 17, 2025
6ad6b22
remove 0.0.0.0
jsendo Apr 17, 2025
0c146e9
Merge branch 'master' into je/dj-3197-bump-sdk-version-add-debug-readme
jsendo Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions modelcontextprotocol/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,31 @@ If you're running MCP servers for your app, you'll likely want to use the [SSE i

If your user `123` wants to connect to the `slack` MCP server, your MCP client would make a request to the `/123/slack` route. [See the SSE docs below](#sse) for more detail.

### Running the server via locally for development

sse
```bash
npm run dev:sse
```

stdio
```bash
npm run dev:stdio
```

optionally you can add add the env var `PD_SDK_DEBUG=true` to the above commands to dump requests and responses to the Pipecream Connect API.

sse
```bash
PD_SDK_DEBUG=true npm run dev:sse
```

stdio
```bash
PD_SDK_DEBUG=true npm run dev:stdio
```


### Running the server via `npx`

Pipedream MCP servers provide [two interfaces](https://modelcontextprotocol.io/docs/concepts/architecture#transport-layer) clients can connect to:
Expand Down
8 changes: 4 additions & 4 deletions modelcontextprotocol/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions modelcontextprotocol/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"@pipedream/mcp": "./dist/src/cli.js"
},
"scripts": {
"dev:stdio": "tsx watch src/stdio.ts",
"dev:sse": "tsx watch src/sse.ts",
"dev:stdio": "tsx watch -r dotenv/config src/stdio.ts",
"dev:sse": "tsx watch -r dotenv/config src/sse.ts",
"start:stdio": "tsx src/cli.ts stdio",
"start:sse": "tsx src/cli.ts sse",
"start:stdio:app": "tsx src/cli.ts stdio --app",
Expand All @@ -20,7 +20,7 @@
},
"dependencies": {
"@modelcontextprotocol/sdk": "^1.7.0",
"@pipedream/sdk": "^1.4.0",
"@pipedream/sdk": "^1.5.2",
"commander": "^13.1.0",
"cors": "^2.8.5",
"express": "^4.21.2",
Expand Down
2 changes: 1 addition & 1 deletion modelcontextprotocol/src/sse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
})

app
.listen(port, () => {
.listen(port,"0.0.0.0", () => {

Check failure on line 163 in modelcontextprotocol/src/sse.ts

View workflow job for this annotation

GitHub Actions / Lint Code Base 

A space is required after ','
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix linting error: missing space after comma.

There's a missing space after the comma in .listen(port,"0.0.0.0", () => {.

-.listen(port,"0.0.0.0", () => {
+.listen(port, "0.0.0.0", () => {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.listen(port,"0.0.0.0", () => {
.listen(port, "0.0.0.0", () => {
🧰 Tools
🪛 GitHub Check: Lint Code Base

[failure] 163-163:
A space is required after ','

🪛 GitHub Actions: Pull Request Checks

[error] 163-163: ESLint: A space is required after ',' (comma-spacing)

console.log(`Server is running on port ${port}`)
console.log("Routes configured:")
console.log("- GET / - Health check")
Expand Down
Loading