Google Sheets - fix metadata id emit #17294

andrewjschuang · 2025-06-25T19:57:58Z

WHY

Summary by CodeRabbit

Bug Fixes
- Improved consistency of event identifiers for new row triggers in Google Sheets by removing the timestamp from event IDs.
Chores
- Updated version numbers for the Google Sheets integration package and new row trigger components.

vercel · 2025-06-25T19:58:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)	Visit Preview	Jun 25, 2025 8:04pm
pipedream-docs	⬜️ Ignored (Inspect)		Jun 25, 2025 8:04pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)		Jun 25, 2025 8:04pm

coderabbitai · 2025-06-25T19:59:44Z

Walkthrough

The changes update version numbers in the @pipedream/google_sheets package and its "new row added" source components. Additionally, the getMeta method now accepts a rowHashString parameter and sets the event id directly from it, removing the previous construction from sheetId, row number, and timestamp.

Changes

File(s)	Change Summary
components/google_sheets/package.json	Bumped package version from 0.8.3 to 0.8.4
components/google_sheets/sources/new-row-added/new-row-added.mjs	Updated component version from 0.1.11 to 0.1.12
components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs	Updated component version from 0.0.3 to 0.0.4
components/google_sheets/sources/common/new-row-added.mjs	Modified `getMeta` signature to accept `rowHashString`; event `id` set directly from it instead of constructing from sheetId, rowNumber, and timestamp

Sequence Diagram(s)

sequenceDiagram
    participant GoogleSheetsSource as Google Sheets Source
    participant Worksheet as Worksheet
    participant EventConsumer as Event Consumer

    GoogleSheetsSource->>Worksheet: Detect new row (rowNumber)
    Worksheet-->>GoogleSheetsSource: Return row data
    GoogleSheetsSource->>GoogleSheetsSource: Compute rowHashString
    GoogleSheetsSource->>GoogleSheetsSource: getMeta(worksheet, rowNumber, rowHashString)
    Note right of GoogleSheetsSource: Set event id = rowHashString
    GoogleSheetsSource->>EventConsumer: Emit event with id, summary, ts

Poem

A version hop, a tidy tweak,
Row events now unique and sleek.
No more timestamps in the id’s flow,
Just sheet and row, so you’ll always know.
The bunny hops and gives a cheer—
Google Sheets changes, crystal clear!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:201:49)

components/google_sheets/sources/common/new-row-added.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:201:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da83e37 and 8136ba3.

📒 Files selected for processing (2)

components/google_sheets/sources/common/new-row-added.mjs (2 hunks)
components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs

🚧 Files skipped from review as they are similar to previous changes (1)

components/google_sheets/sources/common/new-row-added.mjs

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Lint Code Base
GitHub Check: Publish TypeScript components
GitHub Check: Verify TypeScript components

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

michelle0927

LGTM!

andrewjschuang added 2 commits June 25, 2025 16:56

remove ts from id metadata when emitting event

e7d51a5

bump versions

da83e37

andrewjschuang added 2 commits June 25, 2025 17:02

use row hash string as id

3d331bc

bump versions

8136ba3

michelle0927 approved these changes Jun 25, 2025

View reviewed changes

andrewjschuang merged commit a190ca5 into master Jun 25, 2025
11 checks passed

andrewjschuang deleted the google-sheets-fix-metadata-id-emit branch June 25, 2025 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Google Sheets - fix metadata id emit #17294

Google Sheets - fix metadata id emit #17294

Uh oh!

andrewjschuang commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

michelle0927 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Google Sheets - fix metadata id emit #17294

Google Sheets - fix metadata id emit #17294

Uh oh!

Conversation

andrewjschuang commented Jun 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY

Summary by CodeRabbit

Uh oh!

vercel bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

michelle0927 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewjschuang commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 25, 2025 •

edited

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)