Skip to content

Google Sheets - fix metadata id emit #17294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

Google Sheets - fix metadata id emit #17294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7d51a5
remove ts from id metadata when emitting event
andrewjschuang Jun 25, 2025
da83e37
bump versions
andrewjschuang Jun 25, 2025
3d331bc
use row hash string as id
andrewjschuang Jun 25, 2025
8136ba3
bump versions
andrewjschuang Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/google_sheets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/google_sheets",
"version": "0.8.3",
"version": "0.8.4",
"description": "Pipedream Google_sheets Components",
"main": "google_sheets.app.mjs",
"keywords": [
Expand Down
6 changes: 3 additions & 3 deletions components/google_sheets/sources/common/new-row-added.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ export default {
_setRowHashes(rowHashes) {
this.db.set("rowHashes", rowHashes);
},
getMeta(worksheet, rowNumber) {
getMeta(worksheet, rowNumber, rowHashString) {
const ts = Date.now();
const id = `${worksheet.properties.sheetId}${rowNumber}${ts}`;
const id = rowHashString;
const summary = `New row #${rowNumber} in ${worksheet.properties.title}`;
return {
id,
Expand Down Expand Up @@ -178,7 +178,7 @@ export default {
worksheet,
rowNumber,
},
this.getMeta(worksheet, rowNumber),
this.getMeta(worksheet, rowNumber, rowHashString),
);
}
this._setRowHashes(rowHashes);
Expand Down
2 changes: 1 addition & 1 deletion components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default {
key: "google_sheets-new-row-added-polling",
name: "New Row Added",
description: "Emit new event each time a row or rows are added to the bottom of a spreadsheet.",
version: "0.0.3",
version: "0.0.4",
dedupe: "unique",
type: "source",
props: {
Expand Down
2 changes: 1 addition & 1 deletion components/google_sheets/sources/new-row-added/new-row-added.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default {
key: "google_sheets-new-row-added",
name: "New Row Added (Instant)",
description: "Emit new event each time a row or rows are added to the bottom of a spreadsheet.",
version: "0.1.11",
version: "0.1.12",
dedupe: "unique",
type: "source",
props: {
Expand Down
Loading