Fix crash in SpinImageEstimation - #5586
Merged
Merged
Conversation
The image width (set by the user) must fit together with the size of the output histogram. `setImageWidth` now checks the given parameter and provides advice if they do not work well together. Minor additional change: in the constructor, change the assert to an if-statement since the support_angle_cos should always be checked. Fixes PointCloudLibrary#1834 Fixes PointCloudLibrary#5039 (already closed, but same issue)
mvieth
added
module: features
changelog: fix
larshg
reviewed
Jan 21, 2023
larshg
approved these changes
Jan 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image width (set by the user) must fit together with the size of the output histogram.
setImageWidthnow checks the given parameter and provides advice if they do not work well together.Minor additional change: in the constructor, change the assert to an if-statement since the support_angle_cos should always be checked.
Fixes #1834
Fixes #5039 (already closed, but same issue)