Added modernize-return-braced-init-list to clang-tidy checks - #5593
Merged
mvieth merged 5 commits intoFeb 11, 2023
Merged
Conversation
gnawme
force-pushed
the
norm.evangelista/add-modernize-return-braced-init-list
branch
from
February 1, 2023 23:33
d18d663 to
eb1e81f
Compare
Added modernize-return-braced-init-list clang-tidy check Fixed issues flagged by clang-tidy Fixed clang-tidy complaints from CI Worked around clang bug with explicit constructor Fixed unrelated unused typedef error Fixed formatting issue
gnawme
force-pushed
the
norm.evangelista/add-modernize-return-braced-init-list
branch
from
February 2, 2023 05:47
80d6262 to
2bf72c6
Compare
Member
|
I don't like all the formatting changes in openni2_grabber.cpp. Please undo them, they have nothing to do with the clang-tidy check and make this PR unnecessarily large. |
Contributor
Author
I think these resulted from running |
Contributor
|
the format changes in |
mvieth
reviewed
Feb 6, 2023
larshg
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
modernize-return-braced-init-listclang-tidycheck