Remove last usage of boost::date_time and replace it with std::chrono

[larshg]

No description provided.

[larshg]

If someone could test this with an actual device, it would be nice 😄

[larshg]

Format would be a bit different:
https://godbolt.org/z/jrKoqnrrT
Should we implement our own formatting of the filenames?

[mvieth]

I think it would be good if we keep the current format.
I had the idea to use std::strftime or std::put_time to replace to_iso_string, but it seems like they don't support sub-second resolution, which we would need.
This stackoverflow question gives some ideas, maybe we can do something similar to this answer?

[larshg]

I think it would be good if we keep the current format. I had the idea to use std::strftime or std::put_time to replace to_iso_string, but it seems like they don't support sub-second resolution, which we would need. This stackoverflow question gives some ideas, maybe we can do something similar to this answer?

Yeah, I thought about adding a common function for quering a timepoint friendly name, with that format. However the - is removed, so it only contains T and ..
I'll see when I get time 👍

[mvieth]

"%Y%m%dT%H%M%S" could work to imitate the first part of to_iso_string

[mvieth]

I found some more occurrences of date_time:

apps/src/openni_klt.cpp:#include <boost/date_time/posix_time/posix_time.hpp> // for to_iso_string, local_time
cmake/pcl_pclconfig.cmake:set(PCLCONFIG_AVAILABLE_BOOST_MODULES "system filesystem date_time iostreams")
common/include/pcl/common/boost.h:#include <boost/date_time/posix_time/posix_time.hpp>
gpu/kinfu_large_scale/tools/kinfuLS_app.cpp:#include <boost/date_time/posix_time/posix_time.hpp> // for microsec_clock::local_time
gpu/kinfu/tools/kinfu_app.cpp:#include <boost/date_time/posix_time/posix_time.hpp> // for microsec_clock::local_time
io/include/pcl/io/boost.h:#include <boost/date_time/posix_time/posix_time.hpp>
io/src/image_grabber.cpp:#include <boost/date_time/posix_time/posix_time.hpp> // for posix_time
visualization/include/pcl/visualization/boost.h:#include <boost/date_time/posix_time/posix_time.hpp>

[mvieth]

The last remaining mentions of date_time I found:
In pcl_pclconfig.cmake
And the apt package libboost-date-time-dev in .dev/docker/env/Dockerfile, .dev/docker/release/Dockerfile, and .dev/docker/ubuntu-variety/Dockerfile (I would suggest to replace these by libboost-serialization-dev which was implicitly installed by libboost-date-time-dev, see https://packages.ubuntu.com/kinetic/libboost-date-time1.74-dev)

[larshg]

This seems to have been changed a lot compared to the openni_viewer_simple.cpp. but I just updated the sleep method and left the rest alone, since its grown quite a lot in LOCs.