Skip to content

Add hints for ordering of -matrix arguments for pcl_transform_point_cloud - #5646

Merged
larshg merged 1 commit into
PointCloudLibrary:masterfrom
themightyoarfish:patch-2
Apr 3, 2023
Merged

Add hints for ordering of -matrix arguments for pcl_transform_point_cloud#5646
larshg merged 1 commit into
PointCloudLibrary:masterfrom
themightyoarfish:patch-2

Conversation

@themightyoarfish

Copy link
Copy Markdown
Contributor

Intuitively I would have assumed row by row ordering, but actually you have to use column by column.

…loud

Intuitively I would have assumed row by row ordering, but actually you have to use column by column.
@themightyoarfish

Copy link
Copy Markdown
Contributor Author

Although maybe this depends on the Eigen storage order used during pcl or client project build?

@mvieth mvieth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larshg

larshg commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Intuitively I would have assumed row by row ordering, but actually you have to use column by column.

Yeah, default for Eigen is col-major:
If the storage order is not specified, then Eigen defaults to storing the entry in column-major. This is also the case if one of the convenience typedefs (Matrix3f, ArrayXXd, etc.) is used.

https://eigen.tuxfamily.org/dox/group__TopicStorageOrders.html

@larshg larshg added this to the pcl-1.13.1 milestone Apr 3, 2023
@larshg
larshg merged commit 472e154 into PointCloudLibrary:master Apr 3, 2023
@themightyoarfish
themightyoarfish deleted the patch-2 branch November 3, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants