Skip to content

fix a bug in demo#6

Merged
niconiconi merged 1 commit intomainfrom
hc/fix_demo_bug
Mar 3, 2026
Merged

fix a bug in demo#6
niconiconi merged 1 commit intomainfrom
hc/fix_demo_bug

Conversation

@hczphn
Copy link
Copy Markdown
Collaborator

@hczphn hczphn commented Mar 3, 2026

Summary

  • pnpm run demo:node -- --help crashed because parseArgs treated
    --help as a positional argument, not a flag. The CLI then tried to
    dispatch "--help" as an unknown command.
  • Added command === 'help' and command === '--help' checks so help
    text is shown regardless of how the argument is parsed.

Test plan

  • Run pnpm run demo:node -- --help — should print help text
  • Run pnpm run demo:node -- help — should print help text
  • Run pnpm run demo:node (no args) — should print help text

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the Node.js demo application's command-line interface. Previously, attempting to access the help documentation using --help would result in a crash due to misinterpretation of the argument. The changes ensure robust handling of help requests, improving the user experience and reliability of the demo.

Highlights

  • Bug Fix: Resolved an issue where pnpm run demo:node -- --help crashed because parseArgs incorrectly treated --help as a positional argument, leading to an unknown command error.
  • Improved Help Command Handling: Added explicit checks for command === 'help' and command === '--help' within the runCli function to ensure the help text is displayed correctly, regardless of how the argument is parsed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • demos/node/src/cli/main.ts
    • Modified the runCli function to include additional checks for 'help' and '--help' as commands.
    • Ensured that the help text is displayed when 'help' or '--help' are passed as positional arguments.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hczphn hczphn requested review from es-kt and niconiconi March 3, 2026 03:03
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug where the demo CLI would crash when --help was passed as a positional argument. The fix correctly identifies various ways of requesting help and displays the help text. The change is correct and addresses the issue. I've added one suggestion to improve the readability and maintainability of the condition for checking if help was requested.

const { positionals, flags } = parseArgs(argv);
const command = positionals[0];
if (!command || flags.help) {
if (!command || command === 'help' || command === '--help' || flags.help) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this logic is correct, for better readability and maintainability, you could group the help command checks. Using an array for help commands makes it easier to add more aliases in the future.

Suggested change
if (!command || command === 'help' || command === '--help' || flags.help) {
if (!command || ['help', '--help'].includes(command) || flags.help) {

@niconiconi niconiconi merged commit 9263647 into main Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants