Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Node.js demo application's command-line interface. Previously, attempting to access the help documentation using Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where the demo CLI would crash when --help was passed as a positional argument. The fix correctly identifies various ways of requesting help and displays the help text. The change is correct and addresses the issue. I've added one suggestion to improve the readability and maintainability of the condition for checking if help was requested.
| const { positionals, flags } = parseArgs(argv); | ||
| const command = positionals[0]; | ||
| if (!command || flags.help) { | ||
| if (!command || command === 'help' || command === '--help' || flags.help) { |
There was a problem hiding this comment.
While this logic is correct, for better readability and maintainability, you could group the help command checks. Using an array for help commands makes it easier to add more aliases in the future.
| if (!command || command === 'help' || command === '--help' || flags.help) { | |
| if (!command || ['help', '--help'].includes(command) || flags.help) { |
Summary
pnpm run demo:node -- --helpcrashed becauseparseArgstreated--helpas a positional argument, not a flag. The CLI then tried todispatch
"--help"as an unknown command.command === 'help'andcommand === '--help'checks so helptext is shown regardless of how the argument is parsed.
Test plan
pnpm run demo:node -- --help— should print help textpnpm run demo:node -- help— should print help textpnpm run demo:node(no args) — should print help text