Skip to content

fix a bug in demo #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niconiconi merged 1 commit into from
Mar 3, 2026
Merged

fix a bug in demo #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demos/node/src/cli/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Notes:
export async function runCli(argv: string[]) {
const { positionals, flags } = parseArgs(argv);
const command = positionals[0];
if (!command || flags.help) {
if (!command || command === 'help' || command === '--help' || flags.help) {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this logic is correct, for better readability and maintainability, you could group the help command checks. Using an array for help commands makes it easier to add more aliases in the future.

Suggested change
if (!command || command === 'help' || command === '--help' || flags.help) {
if (!command || ['help', '--help'].includes(command) || flags.help) {

process.stdout.write(helpText.trimStart());
process.stdout.write('\n');
return;
Expand Down