Skip to content

refactor: simplify and reorganize panel components#138

Merged
jonathanlab merged 4 commits intomainfrom
panel-components-refactor
Nov 19, 2025
Merged

refactor: simplify and reorganize panel components#138
jonathanlab merged 4 commits intomainfrom
panel-components-refactor

Conversation

@jonathanlab
Copy link
Contributor

@jonathanlab jonathanlab commented Nov 18, 2025

PanelLayout was getting way too complex, so we split it up into some more reasonable parts.

- Add Vitest configuration with jsdom environment
- Configure TypeScript for test files
- Create test setup with React Testing Library
- Add test fixtures for panel testing
- Add test helpers and utilities
- Add Vitest dependencies (testing-library, vitest, jsdom)
- Create CodeMirrorEditor component with syntax highlighting
- Add CodeEditorPanel that loads files from repository
- Add IPC handler to read repository files securely
- Add CodeMirror dependencies (state, view)
- Update gitignore
…tore

- Create centralized panelLayoutStore managing layouts for multiple tasks
- Add comprehensive unit tests
- Extract panel manipulation logic into helpers
- Add constants for default panel IDs and sizes
- Enhance panelTree utilities for tree manipulation
- Extract GroupNodeRenderer and LeafNodeRenderer from PanelLayout
- Add usePanelLayoutHooks for panel interactions
- Simplify PanelLayout through component extraction
- Remove DraggablePanel component
- Update panel component exports
Copy link
Contributor

@lucasheriques lucasheriques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to the PR, but one think i'd love is for us to persist the width in the panel

every time i was opening Array i was always resizing the panels

@jonathanlab
Copy link
Contributor Author

not related to the PR, but one think i'd love is for us to persist the width in the panel

every time i was opening Array i was always resizing the panels

yup layouts should also now be properly persisting now per task

Copy link
Contributor Author

jonathanlab commented Nov 19, 2025

Merge activity

  • Nov 19, 10:36 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 19, 10:42 AM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab changed the base branch from graphite-base/138 to main November 19, 2025 10:41
@jonathanlab jonathanlab merged commit 845861f into main Nov 19, 2025
5 of 7 checks passed
@jonathanlab jonathanlab deleted the panel-components-refactor branch November 19, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants