Skip to content

feat: integrate code viewer and refactored panels into task detail#139

Merged
jonathanlab merged 5 commits intomainfrom
task-detail-integration
Nov 19, 2025
Merged

feat: integrate code viewer and refactored panels into task detail#139
jonathanlab merged 5 commits intomainfrom
task-detail-integration

Conversation

@jonathanlab
Copy link
Contributor

@jonathanlab jonathanlab commented Nov 18, 2025

Now that we've detached the panel logic from the renderer in the previous PRs, we can hook it all up here and get rid of the old taskPanelLayoutStore. Also look at how stupidly simple TaskDetail.tsx​ becomes :) Also added a whole bunch of panel splitting tests because there are a lot of edge cases there. Also hooked up the code mirror editor to the file tree panel.

- Add Vitest configuration with jsdom environment
- Configure TypeScript for test files
- Create test setup with React Testing Library
- Add test fixtures for panel testing
- Add test helpers and utilities
- Add Vitest dependencies (testing-library, vitest, jsdom)
- Create CodeMirrorEditor component with syntax highlighting
- Add CodeEditorPanel that loads files from repository
- Add IPC handler to read repository files securely
- Add CodeMirror dependencies (state, view)
- Update gitignore
…tore

- Create centralized panelLayoutStore managing layouts for multiple tasks
- Add comprehensive unit tests
- Extract panel manipulation logic into helpers
- Add constants for default panel IDs and sizes
- Enhance panelTree utilities for tree manipulation
- Extract GroupNodeRenderer and LeafNodeRenderer from PanelLayout
- Add usePanelLayoutHooks for panel interactions
- Simplify PanelLayout through component extraction
- Remove DraggablePanel component
- Update panel component exports
- Migrate from taskPanelLayoutStore to centralized panelLayoutStore
- Add TabContentRenderer for code viewer integration
- Add comprehensive integration tests for panel splitting
- Simplify TaskDetail component
- Remove deprecated useTaskArtifacts hook
- Delete old taskPanelLayoutStore
@jonathanlab jonathanlab marked this pull request as ready for review November 18, 2025 18:23
@jonathanlab jonathanlab requested a review from a team as a code owner November 18, 2025 18:23
Copy link
Contributor

@lucasheriques lucasheriques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

</PanelGroupTree>
}
/>
<PanelLayout taskId={taskId} task={task} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this

Copy link
Contributor Author

jonathanlab commented Nov 19, 2025

Merge activity

  • Nov 19, 10:36 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 19, 10:43 AM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab changed the base branch from panel-components-refactor to graphite-base/139 November 19, 2025 10:42
@jonathanlab jonathanlab changed the base branch from graphite-base/139 to main November 19, 2025 10:42
@jonathanlab jonathanlab merged commit 1ec96ae into main Nov 19, 2025
5 of 7 checks passed
@jonathanlab jonathanlab deleted the task-detail-integration branch November 19, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants