Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
joshsny
left a comment
joshsny
left a comment
There was a problem hiding this comment.
Looks good generally, left a couple comments, approving not to block you
| const taskSlug = (task as any).slug || task.id; | ||
|
|
||
| // Create a session for this task run | ||
| const sessionId = uuidv7(); |
There was a problem hiding this comment.
Can we use the task run id as the session id here? Don't really see a need to seperate them
There was a problem hiding this comment.
Yes, fully agree. I'm currently working on getting that in.
| * Add a custom notification following ACP extensibility model. | ||
| * Method names should start with underscore (e.g., `_posthog/phase_start`). | ||
| */ | ||
| addNotification( |
There was a problem hiding this comment.
These will replace AgentEvent's, right?
There was a problem hiding this comment.
Correct! In the next PR i delete all AgentEvent logic
| * Update the task run associated with a session. | ||
| */ | ||
| async updateTaskRun( | ||
| sessionId: string, |
There was a problem hiding this comment.
Same here with sessions, it's confusing to me why we want to decouple these concepts, they seem like the same thing
There was a problem hiding this comment.
They are, and are tied together int he next PR
| posthogApiUrl: string; | ||
| posthogApiKey: string; | ||
| posthogProjectId: number; | ||
| // PostHog API configuration (optional - enables PostHog integration when provided) |
There was a problem hiding this comment.
Why are we marking these as optional - we only want this to be used via the gateway and with a posthog integration?
There was a problem hiding this comment.
That's true, will fix
jonathanlab
force-pushed
the
12-01-feat_add_session_loading
branch
from
2ba2644 to
a4abecc
Compare
jonathanlab
force-pushed
the
12-01-feat_taskrunv2
branch
from
11aa446 to
f2c2e39
Compare
Merge activity
|
jonathanlab
changed the base branch from
12-01-feat_add_session_loading
to
graphite-base/178
jonathanlab
force-pushed
the
12-01-feat_taskrunv2
branch
from
f2c2e39 to
492bd6c
Compare
2 participants
Hooks up the claude adapter to agent.ts. Remove usage of EventAgent. Update example client to show usage.