Skip to content

Comments

feat: hook up agent acp setup to electron#181

Merged
jonathanlab merged 1 commit intomainfrom
12-02-feat_hook_up_agent_acp_setup_to_electron
Dec 2, 2025
Merged

feat: hook up agent acp setup to electron#181
jonathanlab merged 1 commit intomainfrom
12-02-feat_hook_up_agent_acp_setup_to_electron

Conversation

@jonathanlab
Copy link
Contributor

@jonathanlab jonathanlab commented Dec 2, 2025

This does a lot of stuff: it fixes a bunch of mistakes I made in the previous PRs regarding how we handle ACP.

notably:

  • the acp session id is now the task run id
  • for every action taken via ACP, we now write to S3 instead of manually appending (both client and agent)

Note: this does not yet support polling through cloud, we can do that in a separate PR. The UI is also very rough and will be refactored in another PR. We'll also then pass through the actual prompt we use in the task description, instead of requiring the user to input something.

image.png

This was referenced Dec 2, 2025
Copy link
Contributor Author

jonathanlab commented Dec 2, 2025

@wiz-7ad640923b
Copy link

wiz-7ad640923b bot commented Dec 2, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 2 Medium 1 Low
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Total 2 Medium 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@jonathanlab jonathanlab marked this pull request as ready for review December 2, 2025 13:38
@jonathanlab jonathanlab requested a review from a team as a code owner December 2, 2025 13:38
@jonathanlab jonathanlab force-pushed the 12-02-feat_hook_up_agent_acp_setup_to_electron branch 3 times, most recently from 58e3807 to 086046f Compare December 2, 2025 14:47
Copy link
Contributor Author

jonathanlab commented Dec 2, 2025

Merge activity

  • Dec 2, 4:14 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 2, 4:22 PM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 2, 4:24 PM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab changed the base branch from 12-01-feat_taskrunv2 to graphite-base/181 December 2, 2025 16:19
@jonathanlab jonathanlab changed the base branch from graphite-base/181 to main December 2, 2025 16:20
@jonathanlab jonathanlab force-pushed the 12-02-feat_hook_up_agent_acp_setup_to_electron branch from 086046f to 71a955c Compare December 2, 2025 16:21
@jonathanlab jonathanlab merged commit 9965f30 into main Dec 2, 2025
11 checks passed
@jonathanlab jonathanlab deleted the 12-02-feat_hook_up_agent_acp_setup_to_electron branch December 2, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants