feat: hook up agent acp setup to electron#181
Merged
jonathanlab merged 1 commit intomainfrom Dec 2, 2025
Merged
Conversation
This was referenced Dec 2, 2025
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
58e3807 to
086046f
Compare
joshsny
approved these changes
Dec 2, 2025
Contributor
Author
Merge activity
|
086046f to
71a955c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This does a lot of stuff: it fixes a bunch of mistakes I made in the previous PRs regarding how we handle ACP.
notably:
Note: this does not yet support polling through cloud, we can do that in a separate PR. The UI is also very rough and will be refactored in another PR. We'll also then pass through the actual prompt we use in the task description, instead of requiring the user to input something.