feat(product tours): add tour wait period config#3109
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adboio
force-pushed
the
02-17-feat_product_tours_add_tour_wait_period_config
branch
from
29dc61b to
03eb633
Compare
Contributor
Contributor
|
Size Change: +15.8 kB (+0.24%) Total Size: 6.67 MB
ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
packages/browser/src/extensions/product-tours/product-tours-utils.ts
Outdated
Show resolved
Hide resolved
adboio
force-pushed
the
02-17-feat_product_tours_add_tour_wait_period_config
branch
from
03eb633 to
a7bf6ea
Compare
adboio
force-pushed
the
02-17-feat_product_tours_add_tour_wait_period_config
branch
from
a7bf6ea to
94d7b7a
Compare
lucasheriques
approved these changes
Feb 25, 2026
Contributor
lucasheriques
left a comment
lucasheriques
left a comment
There was a problem hiding this comment.
love that it's well tested
Contributor
Author
|
@lucasheriques thank u i am re-entering my "actually writing tests" era after a hard regression when i first joined :rolling_on_the_floor_laughing: |
adboio
force-pushed
the
02-17-feat_product_tours_add_tour_wait_period_config
branch
from
94d7b7a to
09081fd
Compare
Contributor
Author
adboio
deleted the
02-17-feat_product_tours_add_tour_wait_period_config
branch
adboio
added a commit
to PostHog/posthog
that referenced
this pull request
Feb 27, 2026
## Problem closes #48209 (comment) <!-- Who are we building for, what are their needs, why is this important? --> <!-- Does this fix an issue? Uncomment the line below with the issue ID to automatically close it when merged --> <!-- Closes #ISSUE_ID --> SDK PR: PostHog/posthog-js#3109 ## Changes - adds new wait period config in product tour UI - updates API to handle wait period by adding person property checks to targeting flags <!-- If there are frontend changes, please include screenshots. --> <!-- If a reference design was involved, include a link to the relevant Figma frame! --> ## How did you test this code? <!-- Briefly describe the steps you took. --> <!-- Include automated tests if possible, otherwise describe the manual testing routine. --> <!-- Docs reminder: If this change requires updated docs, please do that! Engineers are the primary people responsible for their documentation. 🙌 --> 👉 _Stay up-to-date with_ [_PostHog coding conventions_](https://posthog.com/docs/contribute/coding-conventions) _for a smoother review._ ## Publish to changelog? <!-- For features only --> <!-- If publishing, you must provide changelog details in the #changelog Slack channel. You will receive a follow-up PR comment or notification. --> <!-- If not, write "no" or "do not publish to changelog" to explicitly opt-out of posting to #changelog. Removing this entire section will not prevent posting. -->
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/benchmarks-posthog
that referenced
this pull request
Feb 27, 2026
## Problem closes PostHog/posthog#48209 (comment) <!-- Who are we building for, what are their needs, why is this important? --> <!-- Does this fix an issue? Uncomment the line below with the issue ID to automatically close it when merged --> <!-- Closes #ISSUE_ID --> SDK PR: PostHog/posthog-js#3109 ## Changes - adds new wait period config in product tour UI - updates API to handle wait period by adding person property checks to targeting flags <!-- If there are frontend changes, please include screenshots. --> <!-- If a reference design was involved, include a link to the relevant Figma frame! --> ## How did you test this code? <!-- Briefly describe the steps you took. --> <!-- Include automated tests if possible, otherwise describe the manual testing routine. --> <!-- Docs reminder: If this change requires updated docs, please do that! Engineers are the primary people responsible for their documentation. 🙌 --> 👉 _Stay up-to-date with_ [_PostHog coding conventions_](https://posthog.com/docs/contribute/coding-conventions) _for a smoother review._ ## Publish to changelog? <!-- For features only --> <!-- If publishing, you must provide changelog details in the #changelog Slack channel. You will receive a follow-up PR comment or notification. --> <!-- If not, write "no" or "do not publish to changelog" to explicitly opt-out of posting to #changelog. Removing this entire section will not prevent posting. -->
tomasfarias
pushed a commit
to PostHog/posthog
that referenced
this pull request
Mar 6, 2026
## Problem closes #48209 (comment) <!-- Who are we building for, what are their needs, why is this important? --> <!-- Does this fix an issue? Uncomment the line below with the issue ID to automatically close it when merged --> <!-- Closes #ISSUE_ID --> SDK PR: PostHog/posthog-js#3109 ## Changes - adds new wait period config in product tour UI - updates API to handle wait period by adding person property checks to targeting flags <!-- If there are frontend changes, please include screenshots. --> <!-- If a reference design was involved, include a link to the relevant Figma frame! --> ## How did you test this code? <!-- Briefly describe the steps you took. --> <!-- Include automated tests if possible, otherwise describe the manual testing routine. --> <!-- Docs reminder: If this change requires updated docs, please do that! Engineers are the primary people responsible for their documentation. 🙌 --> 👉 _Stay up-to-date with_ [_PostHog coding conventions_](https://posthog.com/docs/contribute/coding-conventions) _for a smoother review._ ## Publish to changelog? <!-- For features only --> <!-- If publishing, you must provide changelog details in the #changelog Slack channel. You will receive a follow-up PR comment or notification. --> <!-- If not, write "no" or "do not publish to changelog" to explicitly opt-out of posting to #changelog. Removing this entire section will not prevent posting. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
closes PostHog/posthog#48209 (comment)
Changes
adds new person properties and local storage keys when tours are shown (incl metadata for tour type)
checks tour wait period config against existing local storage keys as part of eligibility checks
person property checks are handled in the feaure flag (main app PR to follow)
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file