Skip to content

ci: homogenize github actions workflows + use trusted publisher #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 16, 2025
Merged

ci: homogenize github actions workflows + use trusted publisher #67

merged 8 commits into from
Jun 16, 2025

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented May 30, 2025 •
edited
Loading

  • Use PyPI trusted publishers
  • This also fixes the PyPI upload, which is currently broken due to revoked API tokens
  • Homogenize some CI workflows to PGM (note that this is still ongoing and may still have some follow-ups)

Checks before merging

do-not-merge-label added:

@mgovers mgovers self-assigned this May 30, 2025
@mgovers mgovers added do-not-merge This should not be merged improvement Improvement on internal implementation labels May 30, 2025
mgovers added 4 commits May 30, 2025 10:59
@mgovers
always release for testing purposes
51d69f1 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix syntax
26c35de 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix typo
b4695cd 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
revert test changes
5aab7f8 
Signed-off-by: Martijn Govers <[email protected]>
This was referenced Jun 5, 2025
Merged
Merged
Thijss
Thijss reviewed Jun 10, 2025
View reviewed changes
@Thijss Thijss mentioned this pull request Jun 10, 2025
Merged
mgovers and others added 3 commits June 10, 2025 13:30
@mgovers @Thijss
Update .github/workflows/build-test-release.yml
f87e124 
Signed-off-by: Martijn Govers <[email protected]>

Co-authored-by: Thijs Baaijen <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix ci-passed cfr. PowerGridModel/power-grid-model#1015
a663b44 
Signed-off-by: Martijn Govers <[email protected]>
@Thijss
Feat/test new pypi (#69)
6e003ca 
* move comments

Signed-off-by: Thijs Baaijen <[email protected]>

* enable test pypi

Signed-off-by: Thijs Baaijen <[email protected]>

* Fix typing issue for numpy 2.3 and python 3.11 (#70)

Signed-off-by: Thijs Baaijen <[email protected]>

---------

Signed-off-by: Thijs Baaijen <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Thijss Thijss removed do-not-merge This should not be merged labels Jun 16, 2025
@Thijss Thijss marked this pull request as ready for review June 16, 2025 13:41
Thijss
Thijss approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@Thijss Thijss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with pointer to pypi-test platform

@Thijss Thijss merged commit 054e7bf into main Jun 16, 2025
23 of 24 checks passed
@Thijss Thijss deleted the feature/pypi-trusted-publishers branch June 16, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thijss Thijss Thijss approved these changes

@figueroa1395 figueroa1395 Awaiting requested review from figueroa1395

@vincentkoppen vincentkoppen Awaiting requested review from vincentkoppen

@jaapschoutenalliander jaapschoutenalliander Awaiting requested review from jaapschoutenalliander

Assignees

@mgovers mgovers

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgovers @Thijss