-
Notifications
You must be signed in to change notification settings - Fork 46
SparseMatrixErrors: power flow and short circuit special case #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nitish Bharambe <[email protected]>
|
Sparse Matrix error in the reported issue occurs at (12,12) which is the 33rd. (case not uploaded here) With small finite impedance of r=1e-6, x=1e-6: (Still gives out SpaarseMatrixError) Minimal test case 1 of power flow calculation happens at (0,0) Minimal test case 2 of short circuit calculation happens at (0,0). |
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
power_grid_model_c/power_grid_model/include/power_grid_model/component/transformer.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nitish Bharambe <[email protected]>
|
@nitbharambe the mismatch in the failed cases is actually pretty small, only like |
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
|
The reasoning for the fail seems too varied. Its 1e-4 in some cases. But I see setting the admittance as 1e-12 worked. (1e-8 or 1e-10 failed as well)
|
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
Signed-off-by: Tony Xiang <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
|
| param0.ytt() = y0_series; | ||
| } | ||
|
|
||
| auto const low_admittance = 0.5 * 1e-12 * sn_ / base_power_3p / uk_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this admittance of susceptance? Since we're only adding it to the imaginary part of Y = G + jB
| param.value[i] = dot(sym_matrix, y012, sym_matrix_inv); | ||
| } | ||
|
|
||
| // for (size_t phase = 0; phase < 3; ++phase) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that there is commented out code here
|
@nitbharambe closing this in favor of #1189 to reduce the number of added test cases. I keep the branch there so you can decide later do you want to archive those additional cases somewhere. |



Relates to issue: #1162
Changes proposed in this PR include:
Only DYn and YnD delta combination is added as the behaviour is same as Y for other windings.
Note that: