Skip to content

Fix zero sequence floating in some scenarios #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Fix zero sequence floating in some scenarios #1189

wants to merge 18 commits into from

Conversation

@TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Nov 16, 2025

Relates to #1162.

Replaces #1175 for simpicity

  • Add a small admittance at zero sequence where unavailable.
  • Adjust unit test
  • Add some validation tests
  • Relax some tolerance of short circuit validation tests

nitbharambe and others added 14 commits November 14, 2025 13:50
@nitbharambe @TonyXiang8787
add small admittance
2a0678e 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe @TonyXiang8787
approach 2
19ed1c2 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe @TonyXiang8787
minor
9d67a7d 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe @TonyXiang8787
minor 2
747a2fb 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe @TonyXiang8787
address comment
829a9b3 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe @TonyXiang8787
try 1e-12
0f27901 
Signed-off-by: Nitish Bharambe <[email protected]>
@TonyXiang8787
try 1e-8
5bbdb86 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
try 1e-6
4d0b9cb 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
try 1e-4
3adfb30 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
back to 1e-8
e39cbe5 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
adjust tolerance
0407b35 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add pf case
709d1b1 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add sc case
c0d48f8 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
fix all test
5b1cf63 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 TonyXiang8787 self-assigned this Nov 16, 2025
@TonyXiang8787 TonyXiang8787 added the bug Something isn't working label Nov 16, 2025
@TonyXiang8787 TonyXiang8787 mentioned this pull request Nov 16, 2025
Closed
@TonyXiang8787
fix error
94e204f 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
separate func
99b0dbd 
Signed-off-by: Tony Xiang <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgovers mgovers mgovers left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@TonyXiang8787 TonyXiang8787

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TonyXiang8787 @mgovers @nitbharambe