Do not attempt regeneration of PS 8 classic images which were manually built #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quetzacoalt91
changed the title
Progi1984
approved these changes
Sep 8, 2025
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken @Progi1984, the classic Dockerfiles were built manually. I suggest removing them from the
versions.pyso the script do not tamper their contents with mandatory variable it is unable to find. The files previously added will remain in the project anyway../prestashop_docker.py generate, we don't end anymore with this kind on line:ADD None /tmp/prestashop.zip