Skip to content

Do not attempt regeneration of PS 8 classic images which were manually built #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quetzacoalt91 merged 2 commits into from
Sep 8, 2025
Merged

Do not attempt regeneration of PS 8 classic images which were manually built #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c9c96
Revert "Always keep data that has been manually added in versions.py"
Quetzacoalt91 Sep 5, 2025
447a3d7
Generate versions.py with ./prestashop_docker.py backlog
Quetzacoalt91 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion prestashop_docker/backlog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def generate(self):

print('Step 3/3: Building list')
versions_dict = self.parse_prestashop_versions(prestashop_data, available_php_versions)
branches_dict = self.previous_state_versions
branches_dict = self.get_branches_and_nightly_from_existing_file()
self.write_versions_py(versions_dict | branches_dict)

def get_available_php_versions(self):
Expand All @@ -49,6 +49,15 @@ def get_available_php_versions(self):
available_versions.add(match.group(1))
return available_versions

# Branches and nightly entries are manually added in versions.py file.
# Let's reuse the existing contents on each generation.
def get_branches_and_nightly_from_existing_file(self):
branches = {}
for branch, php_versions in self.previous_state_versions.items():
if branch == self.NIGHTLY or branch.endswith('x'):
branches[branch] = (tuple(php_versions))
return branches

def parse_prestashop_versions(self, prestashop_json, available_php_versions):
versions = {}
for entry in prestashop_json:
Expand Down
91 changes: 0 additions & 91 deletions versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,27 +162,13 @@
'8.0',
'8.1',
),
'8.0.1-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.0.2': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.0.2-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.0.3': (
'7.2',
'7.3',
Expand All @@ -197,13 +183,6 @@
'8.0',
'8.1',
),
'8.0.4-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.0.5': (
'7.2',
'7.3',
Expand Down Expand Up @@ -232,13 +211,6 @@
'8.0',
'8.1',
),
'8.1.0-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.0-rc.1': (
'7.2',
'7.3',
Expand All @@ -253,97 +225,48 @@
'8.0',
'8.1',
),
'8.1.1-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.2': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.2-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.3': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.3-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.4': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.4-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.5': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.5-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.6': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.6-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.7': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.7-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.1.x': (
'7.2',
'7.3',
Expand All @@ -358,27 +281,13 @@
'8.0',
'8.1',
),
'8.2.0-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.2.1': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.2.1-classic': (
'7.2',
'7.3',
'7.4',
'8.0',
'8.1',
),
'8.2.2': (
'7.2',
'7.3',
Expand Down