fix: support patch releases #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DioEgizio
approved these changes
Jan 7, 2026
Trial97
reviewed
Jan 7, 2026
| let latest_version_parts = semver_split(&latest_version); | ||
|
|
||
| if log_version_parts.len() != 2 | ||
| if log_version_parts.len() != 3 |
Member
There was a problem hiding this comment.
What would happen if the len is 2 as in 9.4?
Member
Author
There was a problem hiding this comment.
If len is 2, then the branch is taken and the outdated message is shown
it's basically what's currently happening with 3, depite having the same numbers.
Member
There was a problem hiding this comment.
Then it'd say that it's outdated. which makes sense
TheKodeToad
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the "version is 10.0.0 and newest is 10.0.0" bug, it will come back if we switch back to two version numbers.