Skip to content

fix: support patch releases #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheKodeToad merged 1 commit into from
Jan 7, 2026
Merged

fix: support patch releases #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/handlers/event/analyze_logs/issues.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,13 @@ async fn outdated_launcher(log: &str, data: &Data) -> Result<Issue> {
};
let latest_version_parts = semver_split(&latest_version);

if log_version_parts.len() != 2
if log_version_parts.len() != 3
Copy link
Member

@Trial97 Trial97 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if the len is 2 as in 9.4?

Copy link
Member Author

@timoreo22 timoreo22 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If len is 2, then the branch is taken and the outdated message is shown

it's basically what's currently happening with 3, depite having the same numbers.

Copy link
Member

@TheKodeToad TheKodeToad Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it'd say that it's outdated. which makes sense

|| log_version_parts[0] < latest_version_parts[0]
|| (log_version_parts[0] == latest_version_parts[0]
&& log_version_parts[1] < latest_version_parts[1])
|| (log_version_parts[0] == latest_version_parts[0]
&& log_version_parts[1] == latest_version_parts[1]
&& log_version_parts[2] < latest_version_parts[2])
{
let issue = if log_version_parts[0] < 8 {
(
Expand Down
Loading