Update cards without hint messages before selections #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was making the player select the zones during the activation, not during the resolution
- Added missing hint messages. - Shouldn't be able to use its effect if you don't have a Plant to place on top of the Deck. - Added missing summon category and opinfo. - Shouldn't be able to Normal Summon if you don't successfully add a card to the hand and place a Plant on top of the Deck.
- Highlight only after checking that a card was selected - Placing on the bottom of the Deck and drawing are simultaneous in the OCG
Use Cost.AND for the shared restriction cost
- Missing target flag - Check that re is a Spell effect rather than the card being a Spell - Should also check face-up for other "Valkyrie" monsters - ATK change should reset on negate and be negatable
- Missing chkc handling - Missing draw opinfo
- Missing possible opinfos - Added more hint timings
- Can't use a 2nd Orcustrated Core to apply the effect on a card that already has the effect applied to it - Use a table for checking multiple archetypes
- Use "Card.IsCanBeEffectTarget" - The "Unchained" monster also needs to be face-up
- Use "Card.NegateEffects" and "aux.DelayedOperation"
Simplify the resolution check and the destroy register logic a bit
- Missing category - Strings - Show a card on resolution, not on activation - Check that the target is still face-up on resolution - Modern "activate 1 of these effects" implementation
Simplifications
General modernisation + hint on the summoned monsters
- CATEGORY_LVCHANGE - lvtg - Should activate even if she's already Level 12 or higher - Yes/No string - Missing space after "return"
The ATK change itself should be unnegatable
- Check that at least 1 card ended up in the Main or Extra Deck - Check for an available zone to summon from the Extra Deck
- Filter name typo - Cannot disable equip limit
Shouldn't be able to copy it with another effect
- Shouldn't be able to use its 1st effect if damage calculation isn't conducted - The destroy effect should resolve doing nothing if this card has already left the field when it resolves - Shouldn't roll a die if the target has already left the GY when it resolves
- Check for zones in the target function if the cost is skipped - Apply the restriction on res only if it's a card activation
Place the revealed card on the bottom of the owner's Deck
- Use "Card.AddMustBeSpecialSummonedByCardEffect" - Should check for the destroyed card's name on the field rather than after it's destroyed
CATEGORY_DEFCHANGE + SET_HERO
- Missing ">0" when checking for available zones with "Duel.GetMZoneCount" - Wrong string id in e2
- Missing CATEGORY_TODECK category and opinfo - Also check for forbidden status and unique on field for the card to equip
Use "Card.IsCanBeXyzMaterial" when attaching from the Pendulum Zone
pyrQ
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following files are possible scripts where Duel.SelectMatchingCard or Duel.SelectTarget are called without Duel.Hint appearing in the line immediately before them, leaving the player without a description during the selection. Might include false positives: