fix: prevent showCollection button from disappearing

[fstoe]

Hey,
this is my idea to fix issue 4152 .

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.91%. Comparing base (470cf46) to head (06f7d7f).
Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
src/state/actions/window.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4154      +/-   ##
==========================================
- Coverage   94.91%   94.91%   -0.01%     
==========================================
  Files         324      324              
  Lines       16150    16152       +2     
  Branches     2533     2533              
==========================================
+ Hits        15329    15330       +1     
- Misses        816      817       +1     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[marlo-longley]

This fix works for me.

[marlo-longley]

@fstoe I actually noticed something I have a question about -- the name of the Collection displayed in the sidebar and dialog

In this image, the sidebar Collection name is "Aarau, Aargauer Kantonsbibliothek"

After clicking the "Show Collection" button and opening the dialog, the name is "E-codices..." in the sidebar, but the Collection name is "Aarau, Aargauer Kantonsbibliothek" in the dialog.

After closing the dialog, the Collection name in the sidebar returns to being "Aarau, Aargauer Kantonsbibliothek"

Is this expected? I honestly do not know the intended behavior. Thanks.

[lutzhelm]

Is this expected?

I doubt it. If you navigate to the parent collection, the collection info vanishes from the info panel. At this point, if you close the collection modal, the collection info keeps missing. The collectionPath in the state is used for two different things that have weird interactions. I'll look into it.

[lutzhelm]

Closed in favor of #4155.