Fix #4152, use separate state for collection info panel and collection selection dialog#4155
Merged
marlo-longley merged 8 commits intomainfrom Jul 17, 2025
Merged
Fix #4152, use separate state for collection info panel and collection selection dialog#4155marlo-longley merged 8 commits intomainfrom
marlo-longley merged 8 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4155 +/- ##
==========================================
+ Coverage 94.91% 95.12% +0.21%
==========================================
Files 325 325
Lines 16152 16153 +1
Branches 2535 2547 +12
==========================================
+ Hits 15331 15366 +35
+ Misses 816 782 -34
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lutzhelm
commented
Jun 25, 2025
| }); | ||
| } else { | ||
| addWindow({ collectionPath: [...collectionPath, manifestId], manifestId: m.id }); | ||
| addWindow({ collectionPath: [...dialogCollectionPath, manifestId], manifestId: m.id }); |
Contributor
Author
There was a problem hiding this comment.
I'm going to leave this line untested. It does not actually make a lot of sense that there would be no windowId. The only way this line is ever executed would be a plugin that reuses this component. Might even remove this path it in a separate PR.
Contributor
Author
marlo-longley
previously approved these changes
Jul 3, 2025
marlo-longley
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for PR #4154; addresses problems mentioned in this comment.