Impl time crate into pyo3 #5057
Conversation
|
There is no implementation for UtcDateTime. Is that a oversight? |
I provided an implementation in earlier commits but I realized that the https://github.com/time-rs/time/blob/v0.3.41/time-core/Cargo.toml I duno if breaking msrv is a good idea so I decided to downgrade time crate back to Should I just bump the msrv and bring back |
|
It is OK to break the msrv in a optional feature. The jiff integration currently does the same thing (see #4823). Just make sure it is documented properly. Further more forcing the time dependency to a fixed version is probably too invasive for users to be usable. So setting the minimum version to |
|
Please document the new feature in the guide as well; https://pyo3.rs/latest/features.html. |
|
looks like main is broken ? @davidhewitt |
src/conversions/time.rs
Outdated
| // // Get UTC timezone | ||
| // #[cfg(not(Py_LIMITED_API))] | ||
| // let py_tzinfo = py | ||
| // .import("datetime")? | ||
| // .getattr(intern!(py, "timezone"))? | ||
| // .getattr(intern!(py, "utc"))?; | ||
| // | ||
| // #[cfg(Py_LIMITED_API)] | ||
| let py_tzinfo = py | ||
| .import("datetime")? | ||
| .getattr(intern!(py, "timezone"))? | ||
| .getattr(intern!(py, "utc"))?; |
There was a problem hiding this comment.
Can should use the utc_timezone function. https://pyo3.rs/main/doc/pyo3/types/fn.timezone_utc
There was a problem hiding this comment.
Thanks. I've switched to use timezone_utc function
src/conversions/time.rs
Outdated
| let is_utc = tzinfo | ||
| .call_method1( | ||
| "__eq__", | ||
| (ob.py() | ||
| .import("datetime")? | ||
| .getattr(intern!(ob.py(), "timezone"))? | ||
| .getattr(intern!(ob.py(), "utc"))?,), | ||
| )? | ||
| .extract::<bool>()?; |
There was a problem hiding this comment.
| let is_utc = tzinfo | |
| .call_method1( | |
| "__eq__", | |
| (ob.py() | |
| .import("datetime")? | |
| .getattr(intern!(ob.py(), "timezone"))? | |
| .getattr(intern!(ob.py(), "utc"))?,), | |
| )? | |
| .extract::<bool>()?; | |
| let is_utc = tzinfo.eq(timezone_utc(py))?; |
There was a problem hiding this comment.
Thanks & changed.
* First draft for implementing time crate into PyO3 * Refactor FromPyObject for PrimitiveDateTime. Disable proptest * Refactor FromPyObject for OffsetDateTime and UtcDateTime * Create extract_date_time function for reusable code * Fix all proptests * Fix doc test * Add changelog * Downgrade time crate version for msrv. Fix clippy error * Remove UtcDateTime * Fix fmt CI failure * Bring back UtcDateTime. Bump time crate to 0.3.38. Add features doc. * Add time feature to noxfile * use timezone_utc. add const SECONDS_PER_DAY. Revise doc example * Fix FromPyObject for UtcDateTime * `intern` only used on limited api --------- Co-authored-by: Icxolu <[email protected]>
3 participants
FIxes #4675
This MR integrates time crate into PyO3 ecosystem. It implements
FromPyObjectandIntoPyObjectfor the following structs from time crate: