Fixed the units of TES standing losses and renamed parameters #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
fneum
approved these changes
Jun 20, 2025
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
LGTM, these units definitely make more sense to me.
TomKae00
requested changes
Jun 25, 2025
Contributor
TomKae00
left a comment
TomKae00
left a comment
There was a problem hiding this comment.
Hey Caspar, thanks for catching the unit mix up! Since all efficiencies and losses in the cost files are stored in per unit, I’d suggest computing standing losses directly in per unit instead of %/h, and dropping the reconversion step in the PyPSA model. That way we keep everything consistent and eliminate an extra conversion downstream.
TomKae00
approved these changes
Jun 26, 2025
Contributor
TomKae00
left a comment
TomKae00
left a comment
There was a problem hiding this comment.
Let’s stick with '%/hour'. Using 'per unit/hour' resulted in too many ndigits, making the values hard to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #229
Changes proposed in this Pull Request
This PR corrects the unit for TES standing losses from per unit to %/hour and renames the parameters:
These latter changes improve naming consistency.
Checklist
doc/release_notes.rstof the upcoming release is included.