[SecondSpectrum] Fix reversed pitch dimensions #404
Merged
probberechts merged 1 commit intoPySport:masterfrom Jan 17, 2025
Merged
[SecondSpectrum] Fix reversed pitch dimensions #404probberechts merged 1 commit intoPySport:masterfrom
probberechts merged 1 commit intoPySport:masterfrom
Conversation
…size_width as pitch_width
probberechts
changed the title
probberechts
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a consistency problem in the use of pitch_size_height and pitch_size_width depending on the format of the metadata file for SecondSpectrum. We made a fix to make the deserializer work in all cases.