Skip to content

[SecondSpectrum] Fix reversed pitch dimensions #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
probberechts merged 1 commit into from
Jan 17, 2025
Merged

[SecondSpectrum] Fix reversed pitch dimensions #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kloppy/infra/serializers/tracking/secondspectrum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ def deserialize(self, inputs: SecondSpectrumInputs) -> TrackingDataset:
first_byte + inputs.meta_data.read()
).match
frame_rate = int(match.attrib["iFrameRateFps"])
pitch_size_height = float(match.attrib["fPitchYSizeMeters"])
pitch_size_width = float(match.attrib["fPitchXSizeMeters"])
pitch_size_height = float(match.attrib["fPitchXSizeMeters"])
pitch_size_width = float(match.attrib["fPitchYSizeMeters"])

periods = []
for period in match.iterchildren(tag="period"):
Expand Down Expand Up @@ -243,7 +243,7 @@ def deserialize(self, inputs: SecondSpectrumInputs) -> TrackingDataset:
# Handles the tracking frame data
with performance_logging("Loading data", logger=logger):
transformer = self.get_transformer(
pitch_length=pitch_size_width, pitch_width=pitch_size_height
pitch_length=pitch_size_height, pitch_width=pitch_size_width
)

def _iter():
Expand Down
Loading