refactor: ConnectionState & Event Handling #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
definitely doesn't work yet, just felt like there was way too much changes not to commit already
Paillat-dev
reviewed
May 13, 2025
Paillat-dev
reviewed
May 13, 2025
Paillat-dev
reviewed
May 13, 2025
Paillat-dev
reviewed
May 13, 2025
large part left is the ConnectionState itself since events haven't been transformed yet
I need to make more commits
Paillat-dev
requested changes
May 16, 2025
Co-authored-by: Paillat <[email protected]> Signed-off-by: VincentRPS <[email protected]>
|
@VincentRPS You should also import defaultdict |
|
Any news ? See traceback of another error here: https://canary.discord.com/channels/881207955029110855/881735314987708456/1373639761696133160 |
|
Congrats @VincentRPS you successfully broke the docs ! 🎉 |
Paillat-dev
requested changes
May 31, 2025
Co-authored-by: Paillat <[email protected]> Signed-off-by: VincentRPS <[email protected]>
|
@VincentRPS I am going to rebase this for you and push here |
M'kay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definitely doesn't work yet