Skip to content

refactor: ConnectionState & Event Handling #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions discord/abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
from .member import Member
from .message import Message, MessageReference, PartialMessage
from .poll import Poll
from .state import ConnectionState
from .app.state import ConnectionState
from .threads import Thread
from .types.channel import Channel as ChannelPayload
from .types.channel import GuildChannel as GuildChannelPayload
Expand Down Expand Up @@ -344,7 +344,7 @@ def __str__(self) -> str:
def _sorting_bucket(self) -> int:
raise NotImplementedError

def _update(self, guild: Guild, data: dict[str, Any]) -> None:
async def _update(self, data: dict[str, Any]) -> None:
raise NotImplementedError

async def _move(
Expand Down Expand Up @@ -594,8 +594,7 @@ def overwrites_for(self, obj: Role | User) -> PermissionOverwrite:

return PermissionOverwrite()

@property
def overwrites(self) -> dict[Role | Member, PermissionOverwrite]:
async def get_overwrites(self) -> dict[Role | Member, PermissionOverwrite]:
"""Returns all of the channel's overwrites.

This is returned as a dictionary where the key contains the target which
Expand All @@ -617,7 +616,7 @@ def overwrites(self) -> dict[Role | Member, PermissionOverwrite]:
if ow.is_role():
target = self.guild.get_role(ow.id)
elif ow.is_member():
target = self.guild.get_member(ow.id)
target = await self.guild.get_member(ow.id)

# TODO: There is potential data loss here in the non-chunked
# case, i.e. target is None because get_member returned nothing.
Expand Down Expand Up @@ -1225,7 +1224,7 @@ async def create_invite(
target_user_id=target_user.id if target_user else None,
target_application_id=target_application_id,
)
invite = Invite.from_incomplete(data=data, state=self._state)
invite = await Invite.from_incomplete(data=data, state=self._state)
if target_event:
invite.set_scheduled_event(target_event)
return invite
Expand Down Expand Up @@ -1605,7 +1604,7 @@ async def send(

ret = state.create_message(channel=channel, data=data)
if view:
state.store_view(view, ret.id)
await state.store_view(view, ret.id)
view.message = ret

if delete_after is not None:
Expand Down
Loading
Loading