Skip to content

revise some outdated squin analysis comments #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnzl-777 merged 1 commit into from
Apr 14, 2025
Merged

revise some outdated squin analysis comments #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/bloqade/squin/analysis/nsites/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ class NSitesAnalysis(Forward[Sites]):
keys = ["op.nsites"]
lattice = Sites

# Take a page from const prop in Kirin,
# I can get the data I want from the SizedTrait
# and go from there
# Take a page from how constprop works in Kirin

## This gets called before the registry look up
def eval_stmt(self, frame: ForwardFrame, stmt: ir.Statement):
Expand All @@ -37,7 +35,7 @@ def eval_stmt(self, frame: ForwardFrame, stmt: ir.Statement):
# For when no implementation is found for the statement
def eval_stmt_fallback(
self, frame: ForwardFrame[Sites], stmt: ir.Statement
) -> tuple[Sites, ...]: # some form of Shape will go back into the frame
) -> tuple[Sites, ...]: # some form of Sites will go back into the frame
return tuple(
(
self.lattice.top()
Expand Down