Skip to content

Fix bug caused by type check fix (bloqade-circuit#566) #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

Fix bug caused by type check fix (bloqade-circuit#566) #542

merged 2 commits into from
Oct 27, 2025

Conversation

@cduck
Copy link
Contributor

@cduck cduck commented Oct 23, 2025

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

Oops. Just look at the one commit I made. Rebasing now.

@cduck cduck force-pushed the cduck/fix-cast-bug branch from 1c3115c to b7cb784 Compare October 23, 2025 17:51
@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

Rebase to main done.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-27 13:37 UTC

@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11382 10149 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/dialects/scf/stmts.py 86% 🟢
TOTAL 86% 🟢

updated for commit: bf8beca by action🐍

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

Satisfying the coverage check will take a bit for me to manually construct an IfElse object from blocks not regions.

@Roger-luo
Copy link
Collaborator

Roger-luo commented Oct 23, 2025

I think we should have some simple test that captures this bug apparently it was not captured by current unit tests.

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

Note that most of the if-else tests are marked xfail due to the recent restriction of no early return statements in scf.

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025 •
edited
Loading

Please review and merge once CI passes.

@cduck
Copy link
Contributor Author

cduck commented Oct 23, 2025

After backporting to 0.17:

@cduck cduck requested a review from Roger-luo October 23, 2025 20:21
@david-pl
Copy link
Contributor

david-pl commented Oct 24, 2025

@Roger-luo should we think about adding downstream testing? That would have also caught this bug.

weinbe58
weinbe58 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-pl david-pl mentioned this pull request Oct 27, 2025
Merged
@Roger-luo Roger-luo merged commit 0c4b028 into main Oct 27, 2025
13 checks passed
@Roger-luo Roger-luo deleted the cduck/fix-cast-bug branch October 27, 2025 13:37
Roger-luo pushed a commit that referenced this pull request Oct 27, 2025
@cduck @Roger-luo
Fix bug caused by type check fix (bloqade-circuit#566) (#542)
84de3fb 
Fixes
[bloqade-circuit/issues/566](QuEraComputing/bloqade-circuit#566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weinbe58 weinbe58 weinbe58 approved these changes

@kaihsin kaihsin kaihsin approved these changes

@Roger-luo Roger-luo Awaiting requested review from Roger-luo

Assignees

No one assigned

Labels

backport 0.17

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failing on main (AttributeError: 'Block' object has no attribute 'blocks')

6 participants

@cduck @Roger-luo @david-pl @weinbe58 @kaihsin