Skip to content

Fix bug caused by type check fix (bloqade-circuit#566) #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

Fix bug caused by type check fix (bloqade-circuit#566) #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cb784
Revert cause of bug while keeping type checking
cduck Oct 23, 2025
bf8beca
Add coverage test
cduck Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/kirin/dialects/scf/stmts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def __init__(
then_body_block = None
else: # then_body.IS_BLOCK:
then_body_block = cast(Block, then_body)
then_body_region = cast(Region, then_body)
then_body_region = Region(then_body_block)

if else_body is None:
else_body_region = ir.Region()
Expand Down
18 changes: 17 additions & 1 deletion test/dialects/scf/test_ifelse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from kirin import ir
from kirin.passes import Fold
from kirin.prelude import python_basic
from kirin.dialects import scf, func, lowering
from kirin.dialects import py, scf, func, lowering

# TODO:
# test_cons
Expand Down Expand Up @@ -150,3 +150,19 @@ def main(n: int):
assert main(2) == 1.0
assert main(1) == 1.0
assert main(0) == 0.0


def test_manual_construct_ifelse_from_blocks():
scf.IfElse(
cond=ir.TestValue(),
then_body=ir.Block(
stmts=[
py.Constant(5),
],
),
else_body=ir.Block(
stmts=[
py.Constant(11),
],
),
)