Try to guess element type from values in ilist.New #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
Roger-luo
reviewed
Nov 6, 2025
| if not values: | ||
| elem_type = types.Any | ||
| else: | ||
| elem_type = values[0].type |
Collaborator
There was a problem hiding this comment.
this is not correct? the type should be union of all elements being used to construct the list.
Contributor
Author
There was a problem hiding this comment.
Oh, my bad. Thanks for fixing it!
david-pl
added a commit
to QuEraComputing/bloqade-circuit
that referenced
this pull request
Nov 7, 2025
CI is blocked by: * Requires kirin main * This kirin PR: QuEraComputing/kirin#563 * This kirin issue: QuEraComputing/kirin#564 Other than that, we should be good. I'm still targeting the kirin upgrade branch to make review easier, but this once the above issues are resolved, this can actually go into `main`. @weinbe58 please have a look at the address analysis, specifically at the `run_lattice` method. I had to change the signature a bit. --------- Co-authored-by: kaihsin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed as part of #344, so I'm not sure if it should be added back. However, without this change we always get
IList[AnyType]unless explicitly specifying the element type inilist.New. This breaks a bunch of tests (and code, really) in bloqade-circuit. Adding this back seemed like the much easier change than explicitly setting theelem_typeeverywhere.