PCVL 1169 CompiledCircuit identifier#719
Open
Benoit-F-Q wants to merge 2 commits intoQuandela:release/1.2.0from
Open
PCVL 1169 CompiledCircuit identifier#719Benoit-F-Q wants to merge 2 commits intoQuandela:release/1.2.0from
Benoit-F-Q wants to merge 2 commits intoQuandela:release/1.2.0from
Conversation
Aubaert
reviewed
Mar 5, 2026
| from perceval.utils.matrix import Matrix | ||
|
|
||
| class CompiledCircuit(ACircuit): | ||
| class Version: |
Contributor
There was a problem hiding this comment.
In python, this is weird to put classes inside other classes as this is not practical to use.
Also, I think you might benefit from using a @dataclasses.dataclass for this class, which will provide automatically the __str__, __repr__ and __eq__, as well as other methods like __ne__
| self.carac_version = packaging.version.Version('0') | ||
| self.phase_at_output = True | ||
| self.empty_mode_list = [] | ||
| self.matrix_uuid = uuid.UUID(int=0) |
Contributor
There was a problem hiding this comment.
What is the purpose of this UUID ?
A int representing the hash of a unitary might be better suited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.