Skip to content

PCVL 1169 CompiledCircuit identifier #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benoit-F-Q wants to merge 2 commits into
base: release/1.2.0
Choose a base branch
from
Open

PCVL 1169 CompiledCircuit identifier #719

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10be8d4
PCVL 1169 CompiledCircuit identifier
Benoit-F-Q Mar 4, 2026
686ec4c
review
Benoit-F-Q Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion perceval/components/compiled_circuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,30 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

from packaging.version import Version
import packaging, uuid

from perceval.components.linear_circuit import ACircuit
from perceval.utils.matrix import Matrix

class CompiledCircuit(ACircuit):
class Version:
Copy link
Copy Markdown
Contributor

@Aubaert Aubaert Mar 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In python, this is weird to put classes inside other classes as this is not practical to use.

Also, I think you might benefit from using a @dataclasses.dataclass for this class, which will provide automatically the __str__, __repr__ and __eq__, as well as other methods like __ne__

def __init__(self):
self.hardware_version = packaging.version.Version('0')
self.carac_version = packaging.version.Version('0')
self.phase_at_output = True
self.empty_mode_list = []
self.matrix_uuid = uuid.UUID(int=0)
Copy link
Copy Markdown
Contributor

@Aubaert Aubaert Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this UUID ?
A int representing the hash of a unitary might be better suited

def __repr__(self):
return f"[{self.hardware_version}, {self.carac_version}, {self.phase_at_output}, {self.matrix_uuid}]"
def __str__(self):
return self.__repr__()
def __eq__(self, other):
return self.hardware_version == other.hardware_version \
and self.carac_version == other.carac_version \
and self.phase_at_output == other.phase_at_output \
and self.empty_mode_list == other.empty_mode_list \
and self.matrix_uuid == other.matrix_uuid

def __init__(self, name: str, template_or_size: ACircuit | int, parameters: list[float], version: Version | None = None):
m = template_or_size if isinstance(template_or_size, int) else template_or_size.m
template = template_or_size if isinstance(template_or_size, ACircuit) else None
Expand Down