Skip to content

docs: separate maintainer guidance from user docs#36

Draft
qartik wants to merge 2 commits intomainfrom
ks/qir2-maintenance
Draft

docs: separate maintainer guidance from user docs#36
qartik wants to merge 2 commits intomainfrom
ks/qir2-maintenance

Conversation

@qartik
Copy link
Member

@qartik qartik commented Mar 6, 2026

Summary

Move maintainer-oriented setup and workflow guidance out of the README and into DEVELOPMENT.md.

Included

  • README focused on installation and usage
  • CONTRIBUTING points to maintainer workflow docs
  • DEVELOPMENT.md for setup, testing, and LLVM maintenance notes

Merge Order

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves maintainer/developer workflow documentation out of the user-facing README into a dedicated DEVELOPMENT.md, keeping contribution guidance linked and easier to find.

Changes:

  • Removed development/setup/testing content from README.md to keep it focused on install + usage.
  • Added DEVELOPMENT.md with setup/build/test/lint/stubs instructions and LLVM upgrade checklist.
  • Updated CONTRIBUTING.md to point contributors to DEVELOPMENT.md (and removed redundant testing details).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
README.md Removes maintainer guidance; adds pointer to DEVELOPMENT.md from Contributing section.
DEVELOPMENT.md New maintainer/developer workflow doc (setup/build/test/LLVM upgrades).
CONTRIBUTING.md Updates contributor onboarding link from README “Development” section to DEVELOPMENT.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +12 to +15
# Install LLVM 21 (macOS/Homebrew example)
brew install llvm@21
export LLVM_SYS_211_PREFIX=/opt/homebrew/opt/llvm@21

Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Homebrew LLVM prefix shown here (/opt/homebrew/opt/llvm@21) is Apple Silicon–specific; on Intel macOS it is typically /usr/local/opt/llvm@21. Please either note both paths (or show a small conditional snippet like the one used in pyproject.toml) to avoid misleading setup instructions.

Copilot uses AI. Check for mistakes.
@qartik qartik force-pushed the ks/qir2-maintenance branch 2 times, most recently from b989e62 to 2417120 Compare March 6, 2026 19:40
@qartik qartik force-pushed the ks/qir2-maintenance branch from 2417120 to 08a3f88 Compare March 6, 2026 19:53
@qartik qartik force-pushed the ks/qir2-maintenance branch from 08a3f88 to 568f804 Compare March 6, 2026 20:03
@qartik qartik changed the base branch from ks/qir2-ci to ks/qir2-core March 6, 2026 20:03
@qartik qartik changed the base branch from ks/qir2-core to main March 6, 2026 20:10
@qartik qartik marked this pull request as draft March 6, 2026 20:10
@qartik qartik force-pushed the ks/qir2-maintenance branch 2 times, most recently from 8d7249b to a24b2e1 Compare March 6, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants